From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934747AbZLGNBj (ORCPT ); Mon, 7 Dec 2009 08:01:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934347AbZLGNBh (ORCPT ); Mon, 7 Dec 2009 08:01:37 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:36296 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932872AbZLGNBg (ORCPT ); Mon, 7 Dec 2009 08:01:36 -0500 Date: Mon, 7 Dec 2009 13:03:39 +0000 From: Alan Cox To: Miklos Szeredi Cc: luto@mit.edu, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] vfs: new O_NODE open flag Message-ID: <20091207130339.620b904b@lxorguk.ukuu.org.uk> In-Reply-To: References: <20091202191549.1dbffa2e@lxorguk.ukuu.org.uk> <20091202204828.4fa0c108@lxorguk.ukuu.org.uk> <4B1A7159.3070101@mit.edu> <20091205202838.3456b6fc@lxorguk.ukuu.org.uk> <20091205231304.03a4af61@lxorguk.ukuu.org.uk> <20091207122346.6d18a8e1@lxorguk.ukuu.org.uk> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In other words, revoking file handles is not enough, we really need to > revoke the _inode_. And if we do that then O_NODE handles are > perfectly harmless. If you have revoke() you are half way there, you also the need to make sure any user cases are updated and well established before you change anything under them. It's not good adding a kernel feature which makes an old udev version insecure.