From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open()
Date: Mon, 7 Dec 2009 15:03:42 +0100 [thread overview]
Message-ID: <20091207150342.23a6cb66@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <4B1D0433.3080506@gmail.com>
On Mon, 07 Dec 2009 14:33:39 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/s390/char/fs3270.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
> index 097d384..2ae58d0 100644
> --- a/drivers/s390/char/fs3270.c
> +++ b/drivers/s390/char/fs3270.c
> @@ -465,7 +465,7 @@ fs3270_open(struct inode *inode, struct file *filp)
> if (IS_ERR(ib)) {
> raw3270_put_view(&fp->view);
> raw3270_del_view(&fp->view);
> - rc = PTR_ERR(fp);
> + rc = PTR_ERR(ib);
> goto out;
> }
> fp->rdbuf = ib;
And added this one as well.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2009-12-07 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 13:33 Roel Kluin
2009-12-07 14:03 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207150342.23a6cb66@mschwide.boeblingen.de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®