From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
"K.Prasad" <prasad@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] don't include asm/hw_breakpoint.h in user space
Date: Mon, 7 Dec 2009 17:12:58 +0100 [thread overview]
Message-ID: <200912071712.58650.arnd@arndb.de> (raw)
In-Reply-To: <10f740e80912061149w277105e2l31e9fef13221fee1@mail.gmail.com>
asm/hw_breakpoint.h is evidently a kernel internal file and should
not be included globally, not even under an #ifdef.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Sunday 06 December 2009, Geert Uytterhoeven wrote:
> `make headers_check' now complains:
>
> usr/include/linux/perf_event.h:22: included file
> 'asm-m68k/hw_breakpoint.h' is not exported
>
> although CONFIG_HAVE_HW_BREAKPOINT is not set.
>
> As <asm/hw_breakpoint.h> exists for x86 only, I guess every one else
> is suffering from this.
Even on x86, that header is not exported.
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -18,10 +18,6 @@
#include <linux/ioctl.h>
#include <asm/byteorder.h>
-#ifdef CONFIG_HAVE_HW_BREAKPOINT
-#include <asm/hw_breakpoint.h>
-#endif
-
/*
* User-space ABI bits:
*/
@@ -451,6 +447,10 @@ enum perf_callchain_context {
# include <asm/perf_event.h>
#endif
+#ifdef CONFIG_HAVE_HW_BREAKPOINT
+#include <asm/hw_breakpoint.h>
+#endif
+
#include <linux/list.h>
#include <linux/mutex.h>
#include <linux/rculist.h>
next prev parent reply other threads:[~2009-12-07 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 19:49 headers_check: asm-*/hw_breakpoint.h is not exported Geert Uytterhoeven
2009-12-07 16:12 ` Arnd Bergmann [this message]
2009-12-08 11:30 ` [tip:perf/urgent] perf events: hw_breakpoints: Don't include asm/hw_breakpoint.h in user space tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912071712.58650.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome