From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: miklos@szeredi.hu, luto@mit.edu, akpm@linux-foundation.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] vfs: new O_NODE open flag
Date: Mon, 7 Dec 2009 17:40:49 +0000 [thread overview]
Message-ID: <20091207174049.50537ddf@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <E1NHfEu-0003SM-U0@pomaz-ex.szeredi.hu>
> Well, yes. That's true. But I still don't think revoke() is the
> answer here. For example even without the possibility of hard links
> there's still a race in udev in the following course of events:
>
> open("/dev/foo", O_RDWR)
> ... open passes permission checks
> ... driver gets unloaded
> ... driver intended for other user gets loaded
> ... open finds new driver
> What we really need is to revoke the *inode*, so that it cannot be
> opened any more. Doing it with unlink() and revoke() and requiring
> that link() does not work on the filesystem is a poor and racy
> substitute for that.
Can't argue with that and going through the kernel logic I don't see
anything preventing an exploit based on that from working.
Alan
next prev parent reply other threads:[~2009-12-07 17:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 16:16 Miklos Szeredi
2009-12-02 19:15 ` Alan Cox
2009-12-02 20:13 ` Miklos Szeredi
2009-12-02 20:48 ` Alan Cox
2009-12-03 5:46 ` Miklos Szeredi
2009-12-05 14:42 ` Andy Lutomirski
2009-12-05 19:40 ` Miklos Szeredi
2009-12-05 20:28 ` Alan Cox
2009-12-05 20:35 ` Miklos Szeredi
2009-12-05 23:13 ` Alan Cox
2009-12-07 6:08 ` Miklos Szeredi
2009-12-07 12:23 ` Alan Cox
2009-12-07 12:41 ` Miklos Szeredi
2009-12-07 12:47 ` Miklos Szeredi
2009-12-07 13:03 ` Alan Cox
2009-12-07 13:08 ` Miklos Szeredi
2009-12-07 13:15 ` Alan Cox
2009-12-07 13:16 ` Miklos Szeredi
2009-12-07 14:13 ` Alan Cox
2009-12-07 14:25 ` Miklos Szeredi
2009-12-07 14:46 ` Alan Cox
2009-12-07 15:11 ` Miklos Szeredi
2009-12-07 17:40 ` Alan Cox [this message]
2009-12-07 15:03 ` Andrew Lutomirski
2009-12-07 15:50 ` Miklos Szeredi
2009-12-07 17:16 ` Alan Cox
2009-12-10 7:39 ` Pavel Machek
2009-12-06 8:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207174049.50537ddf@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®