From: Veaceslav Falico <vfalico@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Al Viro <viro@zeniv.linux.org.uk>,
Miloslav Trmac <mitr@redhat.com>,
James Morris <jmorris@namei.org>, Alan Cox <alan@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Renaud Lottiaux <renaud.lottiaux@kerlabs.com>,
Louis Rilling <louis.rilling@kerlabs.com>,
David Howells <dhowells@redhat.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: [PATCH] kill taskstats_tgid_init() and acct_init_pacct() and cleanup copy_signal()
Date: Mon, 7 Dec 2009 20:45:14 +0100 [thread overview]
Message-ID: <20091207194514.GA20386@darkmag.usersys.redhat.com> (raw)
In-Reply-To: <20091205163314.GB23152@redhat.com>
(on top of previous patchset)
Kill taskstats_tgid_init() and acct_init_pacct() because we don't
need them any more. Cleanup copy_signal() from these functions
and remove the call to task_io_accounting_init() (we can't kill
it because it's still being used by copy_process(), so just removing
it from copy_signal()).
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
--- a/include/linux/taskstats_kern.h 2009-12-07 20:20:02.000000000 +0100
+++ b/include/linux/taskstats_kern.h 2009-12-07 20:20:48.000000000 +0100
@@ -14,10 +14,6 @@
extern struct kmem_cache *taskstats_cache;
extern struct mutex taskstats_exit_mutex;
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{
-}
-
static inline void taskstats_tgid_free(struct signal_struct *sig)
{
if (sig->stats)
@@ -29,8 +25,6 @@ extern void taskstats_init_early(void);
#else
static inline void taskstats_exit(struct task_struct *tsk, int group_dead)
{}
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{}
static inline void taskstats_tgid_free(struct signal_struct *sig)
{}
static inline void taskstats_init_early(void)
--- a/kernel/acct.c 2009-12-07 20:23:43.000000000 +0100
+++ b/kernel/acct.c 2009-12-07 20:24:30.000000000 +0100
@@ -587,14 +587,6 @@ out:
}
/**
- * acct_init_pacct - initialize a new pacct_struct
- * @pacct: per-process accounting info struct to initialize
- */
-void acct_init_pacct(struct pacct_struct *pacct)
-{
-}
-
-/**
* acct_collect - collect accounting information into pacct_struct
* @exitcode: task exit code
* @group_dead: not 0, if this thread is the last one in the process.
--- a/include/linux/acct.h 2009-12-07 20:26:35.000000000 +0100
+++ b/include/linux/acct.h 2009-12-07 20:26:43.000000000 +0100
@@ -123,14 +123,12 @@ struct pacct_struct;
struct pid_namespace;
extern void acct_auto_close_mnt(struct vfsmount *m);
extern void acct_auto_close(struct super_block *sb);
-extern void acct_init_pacct(struct pacct_struct *pacct);
extern void acct_collect(long exitcode, int group_dead);
extern void acct_process(void);
extern void acct_exit_ns(struct pid_namespace *);
#else
#define acct_auto_close_mnt(x) do { } while (0)
#define acct_auto_close(x) do { } while (0)
-#define acct_init_pacct(x) do { } while (0)
#define acct_collect(x,y) do { } while (0)
#define acct_process() do { } while (0)
#define acct_exit_ns(ns) do { } while (0)
--- a/kernel/fork.c 2009-12-07 20:25:18.000000000 +0100
+++ b/kernel/fork.c 2009-12-07 20:36:49.000000000 +0100
@@ -861,17 +861,12 @@ static int copy_signal(unsigned long clo
hrtimer_init(&sig->real_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
sig->real_timer.function = it_real_fn;
- task_io_accounting_init(&sig->ioac);
- taskstats_tgid_init(sig);
-
task_lock(current->group_leader);
memcpy(sig->rlim, current->signal->rlim, sizeof sig->rlim);
task_unlock(current->group_leader);
posix_cpu_timers_init_group(sig);
- acct_init_pacct(&sig->pacct);
-
tty_audit_fork(sig);
sig->oom_adj = current->signal->oom_adj;
next prev parent reply other threads:[~2009-12-07 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 22:10 [PATCH 1/4] copy_signal cleanup: use zalloc and remove initializations Veaceslav Falico
2009-12-02 13:57 ` Oleg Nesterov
2009-12-02 18:27 ` Veaceslav Falico
2009-12-04 14:28 ` [PATCH v2 " Veaceslav Falico
2009-12-05 16:25 ` Oleg Nesterov
2009-12-07 7:34 ` Balbir Singh
2009-12-07 20:36 ` Andrew Morton
2009-12-08 12:37 ` Veaceslav Falico
2009-12-15 10:18 ` [PATCH v3 0/4 -mmotm] copy_signal() cleanup Veaceslav Falico
2009-12-15 10:19 ` [PATCH v3 1/4 -mmotm] copy_signal() cleanup: use zalloc and remove initializations Veaceslav Falico
2009-12-15 10:19 ` [PATCH v3 2/4 -mmotm] copy_signal() cleanup: kill taskstats_tgid_init() and acct_init_pacct() Veaceslav Falico
2009-12-15 10:19 ` [PATCH v3 3/4 -mmotm] copy_signal() cleanup: clean thread_group_cputime_init() Veaceslav Falico
2009-12-15 10:20 ` [PATCH v3 4/4 -mmotm] copy_signal() cleanup: clean tty_audit_fork() Veaceslav Falico
2009-12-04 14:29 ` [PATCH v2 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init() Veaceslav Falico
2009-12-05 16:33 ` Oleg Nesterov
2009-12-07 19:45 ` Veaceslav Falico [this message]
2009-12-07 7:39 ` Balbir Singh
2009-12-04 14:29 ` [PATCH v2 3/4] copy_signal cleanup: clean thread_group_cputime_init() Veaceslav Falico
2009-12-05 16:39 ` Oleg Nesterov
2009-12-04 14:30 ` [PATCH v2 4/4] copy_signal cleanup: clean tty_audit_fork() Veaceslav Falico
2009-12-05 16:58 ` Oleg Nesterov
2009-12-05 20:04 ` Miloslav Trmac
2009-12-06 14:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207194514.GA20386@darkmag.usersys.redhat.com \
--to=vfalico@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.rilling@kerlabs.com \
--cc=mingo@elte.hu \
--cc=mitr@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=renaud.lottiaux@kerlabs.com \
--cc=sgruszka@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome