From: David Miller <davem@davemloft.net>
To: sbrabec@suse.cz
Cc: zambrano@broadcom.com, linux-kernel@vger.kernel.org,
stable@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH][stable] b44 WOL setup: one-bit-off stack corruption kernel panic fix
Date: Tue, 08 Dec 2009 21:00:35 -0800 (PST) [thread overview]
Message-ID: <20091208.210035.37560621.davem@davemloft.net> (raw)
In-Reply-To: <1259852188.8163.58.camel@hammer.suse.cz>
From: Stanislav Brabec <sbrabec@suse.cz>
Date: Thu, 03 Dec 2009 15:56:28 +0100
> About 50% of shutdowns of b44 Ethernet adapter ends by kernel panic with
> kernels compiled with stack-protector.
>
> Checking b44_magic_pattern() return values, one call of
> b44_magic_pattern() returns 127. It means, that set_bit(128, pmask) was
> called on line 1509. It means that bit 0 of 17th byte of pmask was
> overwritten. But pmask has only 16 bytes. Stack corruption happens.
>
> It seems that set_bit() on line 1509 always writes one bit off.
>
> The fix does not only solve the stack corruption, but also makes Wake On
> LAN working on my onboard B44 on Asus A7V-333X mainboard.
>
> It seems that this problem affects all kernel versions since commit
> 725ad800 on 2006-06-20.
>
> Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Applied, thanks.
prev parent reply other threads:[~2009-12-09 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 13:45 Stanislav Brabec
2009-12-02 14:35 ` Stanislav Brabec
2009-12-02 23:42 ` David Miller
2009-12-03 14:56 ` Stanislav Brabec
2009-12-09 5:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208.210035.37560621.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbrabec@suse.cz \
--cc=stable@kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®