From: Jan Kara <jack@suse.cz>
To: root <jeremy.cochoy@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
Manish Katiyar <mkatiyar@gmail.com>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [PATCH] fix ext2 parse_options printk
Date: Tue, 8 Dec 2009 11:00:32 +0100 [thread overview]
Message-ID: <20091208100032.GA4095@quack.suse.de> (raw)
In-Reply-To: <1260194461-8937-2-git-send-email-jeremy.cochoy@gmail.com>
On Mon 07-12-09 15:01:01, root wrote:
> From: Jeremy Cochoy <jeremy.cochoy@gmail.com>
>
> Signed-off-by: Jeremy Cochoy <jeremy.cochoy@gmail.com>
Thanks for the patch but it's actually already fixed in my tree due to
ext2 message unification patches. So should get into 2.6.33-rc1.
Honza
> ---
> fs/ext2/super.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 1a9ffee..f28618f 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -505,7 +505,7 @@ static int parse_options (char * options,
> #else
> case Opt_user_xattr:
> case Opt_nouser_xattr:
> - printk("EXT2 (no)user_xattr options not supported\n");
> + printk(KERN_NOTICE "EXT2 (no)user_xattr options not supported\n");
> break;
> #endif
> #ifdef CONFIG_EXT2_FS_POSIX_ACL
> @@ -518,14 +518,14 @@ static int parse_options (char * options,
> #else
> case Opt_acl:
> case Opt_noacl:
> - printk("EXT2 (no)acl options not supported\n");
> + printk(KERN_NOTICE "EXT2 (no)acl options not supported\n");
> break;
> #endif
> case Opt_xip:
> #ifdef CONFIG_EXT2_FS_XIP
> set_opt (sbi->s_mount_opt, XIP);
> #else
> - printk("EXT2 xip option not supported\n");
> + printk(KERN_NOTICE "EXT2 xip option not supported\n");
> #endif
> break;
>
> @@ -550,11 +550,11 @@ static int parse_options (char * options,
>
> case Opt_reservation:
> set_opt(sbi->s_mount_opt, RESERVATION);
> - printk("reservations ON\n");
> + printk(KERN_INFO "reservations ON\n");
> break;
> case Opt_noreservation:
> clear_opt(sbi->s_mount_opt, RESERVATION);
> - printk("reservations OFF\n");
> + printk(KERN_INFO "reservations OFF\n");
> break;
> case Opt_ignore:
> break;
> --
> 1.5.6.5
>
prev parent reply other threads:[~2009-12-08 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 14:01 root
2009-12-07 14:01 ` root
2009-12-08 10:00 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208100032.GA4095@quack.suse.de \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=corentin.chary@gmail.com \
--cc=hch@lst.de \
--cc=jeremy.cochoy@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®