From: Greg KH <greg@kroah.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Michael Krufky <mkrufky@kernellabs.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org
Subject: 2.6.27.40 build error
Date: Tue, 8 Dec 2009 13:42:46 -0800 [thread overview]
Message-ID: <20091208214246.GA21857@kroah.com> (raw)
It turns out that the patch below causes a build failure on the
2.6.27.40 kernel.
Michael, should I just drop it, or should I take out the line with the
"capture_transfer_done" in it, as that member is not in the structure in
this kernel version.
thanks,
greg k-h
On Thu, Oct 15, 2009 at 01:14:34AM -0300, Devin Heitmueller wrote:
> From: Devin Heitmueller <dheitmueller@kernellabs.com>
>
> commit 96fbf771d86a90ff006bc62ca4d4de6474b3de31 upstream.
>
> Because the counters were not reset when starting up streaming, they would
> be reused from the previous run. This can result in cases such that when the
> second instance of streaming starts up, the "cnt" variable in
> em28xx_audio_isocirq() can end up being negative, resulting in attempting to
> write to memory before the start of runtime->dma_area (as well as having a
> negative number of bytes to copy).
>
> Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Michael Krufky <mkrufky@kernellabs.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> drivers/media/video/em28xx/em28xx-audio.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- a/drivers/media/video/em28xx/em28xx-audio.c
> +++ b/drivers/media/video/em28xx/em28xx-audio.c
> @@ -365,6 +365,11 @@ static int snd_em28xx_hw_capture_free(st
>
> static int snd_em28xx_prepare(struct snd_pcm_substream *substream)
> {
> + struct em28xx *dev = snd_pcm_substream_chip(substream);
> +
> + dev->adev.hwptr_done_capture = 0;
> + dev->adev.capture_transfer_done = 0;
> +
> return 0;
> }
>
next reply other threads:[~2009-12-08 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 21:42 Greg KH [this message]
2009-12-08 21:49 ` Devin Heitmueller
2009-12-08 23:01 ` Greg KH
2009-12-08 23:02 ` Michael Krufky
2009-12-08 23:11 ` Devin Heitmueller
2009-12-09 0:20 ` Michael Krufky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208214246.GA21857@kroah.com \
--to=greg@kroah.com \
--cc=dheitmueller@kernellabs.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mkrufky@kernellabs.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®