mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Michal Marek <mmarek@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [GIT PULL] kbuild updates for 2.6.33
Date: Wed, 9 Dec 2009 20:20:38 +0100	[thread overview]
Message-ID: <20091209192038.GA7827@merkur.ravnborg.org> (raw)
In-Reply-To: <20091209093108.387b2736.randy.dunlap@oracle.com>

On Wed, Dec 09, 2009 at 09:31:08AM -0800, Randy Dunlap wrote:
> On Wed, 9 Dec 2009 10:33:49 +0100 Michal Marek wrote:
> 
> > On Tue, Dec 08, 2009 at 02:30:04PM +0100, Michal Marek wrote:
> > > Hi Linus,
> > > 
> > > these are the kbuild patches I collected for 2.6.33. There might be a few
> > > more later, but this is the main part.
> > > 
> > > Thanks,
> > > Michal
> > > 
> > > The following changes since commit 6ec22f9b037fc0c2e00ddb7023fad279c365324d:
> > >   Linus Torvalds (1):
> > >         Merge branch 'x86-debug-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip
> > > 
> > > are available in the git repository at:
> > > 
> > >   git://repo.or.cz/linux-kbuild.git for-next
> > 
> > Hi Linus,
> > 
> > The kbuild tree now breaks with 250cce26 ("iwlwifi: driver version
> > track kernel version") which you merged yesterday. Stephen Rothwell
> > kindly provided a fix, which I would normally apply to the kbuild tree,
> > but I don't want to rebase it as I already sent the pull request. Could
> > you please apply the following one-liner when merging the kbuild tree?
> > Thanks!
> 
> Hi > Michal,
> 
> Is there anything that tells us when we should/must use
> <generated/*.h> ?

The original idea was that include/generated/ should
be used for all generated header files.

I once had a patch applied that used it for other
generated files - this was a bad idea. Said patch
was reverted as it had much bigger issues.

So think of it as a place for generated header files only.
This also warrants the location in include/

But only for 'global' header files. For drivers
and the like that needs the header file only locally the
header file should not be located n include/generated,
as it is only for the global headers.

asm-offsets.h is a good example here.

	Sam

  reply	other threads:[~2009-12-09 19:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 13:30 Michal Marek
2009-12-08 15:14 ` Michal Marek
2009-12-09  9:33 ` Michal Marek
2009-12-09 17:31   ` Randy Dunlap
2009-12-09 19:20     ` Sam Ravnborg [this message]
2009-12-10 14:12       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091209192038.GA7827@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®