From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759456AbZLJCEA (ORCPT ); Wed, 9 Dec 2009 21:04:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759416AbZLJCDz (ORCPT ); Wed, 9 Dec 2009 21:03:55 -0500 Received: from perceval.irobotique.be ([92.243.18.41]:59649 "EHLO perceval.irobotique.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759405AbZLJCDy (ORCPT ); Wed, 9 Dec 2009 21:03:54 -0500 From: Laurent Pinchart To: Julia Lawall Subject: Re: [PATCH 5/12] drivers/media/video/uvc: Correct size given to memset Date: Thu, 10 Dec 2009 03:05:41 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.31.6; KDE/4.3.4; x86_64; ; ) Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200912100305.41707.laurent.pinchart@ideasonboard.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julia, thanks for the patch. On Wednesday 09 December 2009 20:23:49 Julia Lawall wrote: > From: Julia Lawall > > Memset should be given the size of the structure, not the size of the > pointer. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > type T; > T *x; > expression E; > @@ > > memset(x, E, sizeof( > + * > x)) > // > > Signed-off-by: Julia Lawall Acked-by: Laurent Pinchart -- Regards, Laurent Pinchart