mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: vapier.adi@gmail.com, lethal@linux-sh.org, jie.zhang@analog.com,
	stefani@seibold.net, gerg@snapgear.com
Cc: dhowells@redhat.com, uclinux-dev@uclinux.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] NOMMU: Provide per-task stack usage through /proc for NOMMU
Date: Thu, 10 Dec 2009 13:58:01 +0000	[thread overview]
Message-ID: <20091210135801.6325.15166.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20091210135755.6325.78149.stgit@warthog.procyon.org.uk>

Make it possible to get the per-task stack usage through /proc on a NOMMU
system.  The MMU-mode routine can't be used because walk_page_range() doesn't
work on NOMMU.

It can be tested to show the stack usages of non-kernel-thread processes:

	# grep "Stack usage:" /proc/*/status | grep -v "0 kB"
	/proc/1/status:Stack usage:     2 kB
	/proc/57/status:Stack usage:    3 kB
	/proc/58/status:Stack usage:    1 kB
	/proc/59/status:Stack usage:    3 kB
	/proc/60/status:Stack usage:    5 kB
	/proc/self/status:Stack usage:  1 kB

I've only tested it with ELF-FDPIC, though it should work with FLAT too.

Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Robin Getz <rgetz@blackfin.uclinux.org>
---

 fs/proc/array.c |   20 +++++++++++++++++---
 1 files changed, 17 insertions(+), 3 deletions(-)


diff --git a/fs/proc/array.c b/fs/proc/array.c
index 4badde1..c67251e 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -387,8 +387,7 @@ static inline unsigned long get_stack_usage_in_bytes(struct vm_area_struct *vma,
 	return ss.usage;
 }
 
-static inline void task_show_stack_usage(struct seq_file *m,
-						struct task_struct *task)
+static void task_show_stack_usage(struct seq_file *m, struct task_struct *task)
 {
 	struct vm_area_struct	*vma;
 	struct mm_struct	*mm = get_task_mm(task);
@@ -404,9 +403,24 @@ static inline void task_show_stack_usage(struct seq_file *m,
 		mmput(mm);
 	}
 }
-#else
+#else /* CONFIG_MMU */
+/*
+ * Calculate the size of a NOMMU process's stack
+ */
 static void task_show_stack_usage(struct seq_file *m, struct task_struct *task)
 {
+	unsigned long sp, base, usage;
+
+	base = task->stack_start;
+	sp = KSTK_ESP(task);
+
+#ifdef CONFIG_STACK_GROWSUP
+	usage = sp - base;
+#else
+	usage = base - sp;
+#endif
+
+	seq_printf(m, "Stack usage:\t%lu kB\n", (usage + 1023) >> 10);
 }
 #endif		/* CONFIG_MMU */
 


  reply	other threads:[~2009-12-10 13:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10 13:57 [PATCH 1/7] security: do not check mmap_min_addr on nommu systems David Howells
2009-12-10 13:58 ` David Howells [this message]
2009-12-14 23:33   ` [PATCH 2/7] NOMMU: Provide per-task stack usage through /proc for NOMMU Mike Frysinger
2009-12-10 13:58 ` [PATCH 3/7] NOMMU: fix malloc performance by adding uninitialized flag David Howells
2009-12-10 13:58 ` [PATCH 4/7] FDPIC: Respect PT_GNU_STACK exec protection markings when creating NOMMU stack David Howells
2009-12-10 13:58 ` [PATCH 5/7] NOMMU: Avoiding duplicate icache flushes of shared maps David Howells
2009-12-14 23:55   ` Mike Frysinger
2009-12-15  0:41   ` [uClinux-dev] " Jamie Lokier
2009-12-15  4:52     ` Mike Frysinger
2009-12-15 10:52   ` David Howells
2009-12-10 13:58 ` [PATCH 6/7] NOMMU: Use copy_*_user_page() in access_process_vm() David Howells
2009-12-14 23:51   ` Mike Frysinger
2009-12-10 13:58 ` [PATCH 7/7] NOMMU: ramfs: Drop unused local var David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091210135801.6325.15166.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=gerg@snapgear.com \
    --cc=jie.zhang@analog.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefani@seibold.net \
    --cc=uclinux-dev@uclinux.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome