From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761844AbZLJWAm (ORCPT ); Thu, 10 Dec 2009 17:00:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761619AbZLJWAl (ORCPT ); Thu, 10 Dec 2009 17:00:41 -0500 Received: from rcsinet12.oracle.com ([148.87.113.124]:54351 "EHLO rcsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761550AbZLJWAk (ORCPT ); Thu, 10 Dec 2009 17:00:40 -0500 Date: Thu, 10 Dec 2009 13:59:32 -0800 From: Randy Dunlap To: David Miller Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] net: niu uses crc32, so select CRC32 Message-Id: <20091210135932.b0774727.randy.dunlap@oracle.com> In-Reply-To: <20091210.135138.263963420.davem@davemloft.net> References: <20091210175919.340b4c0c.sfr@canb.auug.org.au> <20091210093103.eda05dfe.randy.dunlap@oracle.com> <20091210.135138.263963420.davem@davemloft.net> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090203.4B216F62.00C3:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Dec 2009 13:51:38 -0800 (PST) David Miller wrote: > From: Randy Dunlap > Date: Thu, 10 Dec 2009 09:31:03 -0800 > > > From: Randy Dunlap > > > > niu drivers uses crc32 functions, so it needs to select CRC32. > > > > niu.c:(.text+0x18a7f8): undefined reference to `crc32_le' > > > > Signed-off-by: Randy Dunlap > > Applied, thanks Randy. > > That dependency is quite indirect, it's due to ether_crc_*(). > I bet a quick grep for that will find several other drivers > missing this Kconfig bit. Yes, I've noticed that also... --- ~Randy