mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: jamie.iles@picochip.com, linux-kernel@vger.kernel.org,
	linux@arm.linux.org.uk, peterz@infradead.org
Subject: Re: [PATCH 1/2] perf tools: allow building for ARM
Date: Fri, 11 Dec 2009 02:38:08 -0800 (PST)	[thread overview]
Message-ID: <20091211.023808.233094506.davem@davemloft.net> (raw)
In-Reply-To: <20091211102316.GB16882@elte.hu>

From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 11 Dec 2009 11:23:16 +0100

> 
> * Jamie Iles <jamie.iles@picochip.com> wrote:
> 
>> +#ifdef __arm__
>> +#include "../../arch/arm/include/asm/unistd.h"
>> +#define rmb()		asm volatile("":::"memory")
>> +#define cpu_relax()	asm volatile("":::"memory")
>> +#endif
> 
> cpu_relax() looks fine, but rmb() seems not to match the one that can be 
> found in arch/arm/:

I think he did it this way so it can compile in the meantime,
and that doing it right requires runtime cpu detection to
select which barrier instruction is even available on the
current ARM cpu.

  parent reply	other threads:[~2009-12-11 10:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  9:20 Jamie Iles
2009-12-11  9:21 ` [PATCH 2/2] perf tools: allow cross compiling Jamie Iles
2009-12-11 10:27   ` [tip:perf/urgent] perf tools: Allow " tip-bot for Jamie Iles
2009-12-11 12:20   ` [PATCH] perf tools: allow building for ARM (patch v2) Jamie Iles
2009-12-11 12:54     ` [tip:perf/urgent] perf tools: Allow building for ARM tip-bot for Jamie Iles
2009-12-11 13:04       ` Jamie Iles
2009-12-11 13:26         ` Ingo Molnar
2009-12-11 10:23 ` [PATCH 1/2] perf tools: allow " Ingo Molnar
2009-12-11 10:30   ` Jamie Iles
2009-12-11 10:38     ` Ingo Molnar
2009-12-11 11:01       ` Jamie Iles
2009-12-11 11:26         ` Mikael Pettersson
2009-12-11 21:22           ` Russell King - ARM Linux
     [not found]     ` <000101ca7a50$b3e2ad70$1ba80850$@deacon@arm.com>
2009-12-11 11:02       ` Ingo Molnar
2009-12-11 11:08         ` Pekka Enberg
2009-12-11 10:38   ` David Miller [this message]
2009-12-11 10:41     ` Ingo Molnar
2009-12-11 11:48       ` Jamie Iles
2009-12-11 12:48         ` Ingo Molnar
2009-12-11 21:19     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211.023808.233094506.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jamie.iles@picochip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®