mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	"K.Prasad" <prasad@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC] Fix 2.6.33 x86 regression to kgdb hw breakpoints - due to perf API changes
Date: Sat, 12 Dec 2009 14:24:28 +0100	[thread overview]
Message-ID: <20091212132428.GB22389@elte.hu> (raw)
In-Reply-To: <4B227F2C.7050403@windriver.com>


* Jason Wessel <jason.wessel@windriver.com> wrote:

> I'll lead with a question.  Are the people making the Perf API changes 
> booting allyesconfig kernels?
>
> The regression tests built into the kernel for kgdb fail as a result 
> of the perf API changes and can result in a hard kernel hang.
>
> My hope would have been that someone would have reported the problem, 
> created a patch to disable the test that hangs the kernel, or to fix 
> kgdb such that it works with the API changes.  Likewise, if there are 
> tests I should run to regression test the changes to the perf API, I 
> would like to know since we all want to make use of the same hw 
> resource.
> 
> A patch has been included in this mail which allows kgdb to pass the 
> internal regression tests for hw breakpoints.  I would like to get 
> some comments or start a discussion as to how to solve this problem in 
> the 2.6.33 cycle, as it is a regression in functionality.

Hm, the kgdb hw-breakpoint changes freshly put into v2.6.33 look pretty 
broken: they access the raw hw registers and ignore the higher level 
abstraction. Your patch still uses way too low level primitives. Please 
use the highlevel abstraction: register/unregister_wide_hw_breakpoint() 
should do the trick. (if there's any changes/extensions needed to it 
then please let us know about it.)

If that's too much for v2.6.33 then i guess we need to revert or disable 
the kgdb hw-breakpoint changes for now.

Thanks,

	Ingo

  reply	other threads:[~2009-12-13  2:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 17:19 Jason Wessel
2009-12-12 13:24 ` Ingo Molnar [this message]
2009-12-12 13:52   ` Ingo Molnar
2009-12-12 21:01     ` Jason Wessel
2009-12-30 16:39       ` Frederic Weisbecker
2009-12-30 16:53         ` [RFC] Fix 2.6.33 x86 regression to kgdb hw breakpoints - dueto " Jason Wessel
2009-12-30 18:01           ` Frederic Weisbecker
2010-01-18 20:13             ` [RFC] Fix 2.6.33 x86 regression to kgdb hw breakpoints - duetoperf " Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091212132428.GB22389@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=jason.wessel@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=prasad@linux.vnet.ibm.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®