From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: pm list <linux-pm@lists.linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH 2/5] PM: Measure device suspend and resume times
Date: Sun, 13 Dec 2009 23:40:13 +0100 [thread overview]
Message-ID: <200912132340.13764.rjw@sisk.pl> (raw)
In-Reply-To: <200912132338.30921.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Measure and print the time of suspending and resuming all devices.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/main.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
Index: linux-2.6/drivers/base/power/main.c
===================================================================
--- linux-2.6.orig/drivers/base/power/main.c
+++ linux-2.6/drivers/base/power/main.c
@@ -383,6 +383,19 @@ static void pm_dev_err(struct device *de
kobject_name(&dev->kobj), pm_verb(state.event), info, error);
}
+static void dpm_show_time(ktime_t starttime, pm_message_t state, char *info)
+{
+ ktime_t calltime, delta;
+ unsigned long long usecs;
+
+ calltime = ktime_get();
+ delta = ktime_sub(calltime, starttime);
+ usecs = (unsigned long long)ktime_to_ns(delta) >> 10;
+ pr_info("PM: %s%s%s of devices complete after %Lu.%03Lu msecs\n",
+ info ?: "", info ? " " : "", pm_verb(state.event),
+ usecs / USEC_PER_MSEC, usecs % USEC_PER_MSEC);
+}
+
/*------------------------- Resume routines -------------------------*/
/**
@@ -419,6 +432,7 @@ static int device_resume_noirq(struct de
void dpm_resume_noirq(pm_message_t state)
{
struct device *dev;
+ ktime_t starttime = ktime_get();
mutex_lock(&dpm_list_mtx);
transition_started = false;
@@ -432,6 +446,7 @@ void dpm_resume_noirq(pm_message_t state
pm_dev_err(dev, state, " early", error);
}
mutex_unlock(&dpm_list_mtx);
+ dpm_show_time(starttime, state, "early");
resume_device_irqs();
}
EXPORT_SYMBOL_GPL(dpm_resume_noirq);
@@ -524,6 +539,7 @@ static int device_resume(struct device *
static void dpm_resume(pm_message_t state)
{
struct list_head list;
+ ktime_t starttime = ktime_get();
INIT_LIST_HEAD(&list);
mutex_lock(&dpm_list_mtx);
@@ -554,6 +570,7 @@ static void dpm_resume(pm_message_t stat
list_splice(&list, &dpm_list);
mutex_unlock(&dpm_list_mtx);
async_synchronize_full();
+ dpm_show_time(starttime, state, NULL);
}
/**
@@ -686,6 +703,7 @@ static int device_suspend_noirq(struct d
int dpm_suspend_noirq(pm_message_t state)
{
struct device *dev;
+ ktime_t starttime = ktime_get();
int error = 0;
suspend_device_irqs();
@@ -701,6 +719,8 @@ int dpm_suspend_noirq(pm_message_t state
mutex_unlock(&dpm_list_mtx);
if (error)
dpm_resume_noirq(resume_event(state));
+ else
+ dpm_show_time(starttime, state, "late");
return error;
}
EXPORT_SYMBOL_GPL(dpm_suspend_noirq);
@@ -800,6 +820,7 @@ static int device_suspend(struct device
static int dpm_suspend(pm_message_t state)
{
struct list_head list;
+ ktime_t starttime = ktime_get();
int error = 0;
INIT_LIST_HEAD(&list);
@@ -831,6 +852,8 @@ static int dpm_suspend(pm_message_t stat
async_synchronize_full();
if (!error)
error = async_error;
+ if (!error)
+ dpm_show_time(starttime, state, NULL);
return error;
}
next prev parent reply other threads:[~2009-12-13 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 22:38 [PATCH 0/5] Async suspend/resume tree Rafael J. Wysocki
2009-12-13 22:39 ` [PATCH 1/5] PM: Asynchronous suspend and resume of devices Rafael J. Wysocki
2009-12-13 22:40 ` Rafael J. Wysocki [this message]
2009-12-13 22:40 ` [PATCH 3/5] PM: Add debug printouts to async suspend and resume code paths Rafael J. Wysocki
2009-12-13 22:41 ` [PATCH 4/5] PM: Add a switch for disabling/enabling asynchronous suspend/resume Rafael J. Wysocki
2009-12-13 22:42 ` [PATCH 5/5] PM: Add facility for advanced testing of async suspend/resume Rafael J. Wysocki
2009-12-15 21:56 ` [PATCH] PM: Allow serio input devices to suspend/resume asynchronously (was: Re: [PATCH 0/5] Async suspend/resume tree) Rafael J. Wysocki
2009-12-21 21:01 [PATCH 0/5] PM patches for the next pull request Rafael J. Wysocki
2009-12-21 21:04 ` [PATCH 2/5] PM: Measure device suspend and resume times Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912132340.13764.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®