From: Willy Tarreau <w@1wt.eu>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
devel@driverdev.osuosl.org,
Sudhakar Rajashekhara <sudhakar.raj@ti.com>,
Costantino Leandro <lcostantino@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compilation error of drivers/staging/panel/panel.c w/ custom lcd charset
Date: Tue, 15 Dec 2009 22:19:53 +0100 [thread overview]
Message-ID: <20091215211953.GE11857@1wt.eu> (raw)
In-Reply-To: <1260854505-17786-1-git-send-email-peterhuewe@gmx.de>
On Tue, Dec 15, 2009 at 06:21:45AM +0100, Peter Huewe wrote:
> When compiling panel.c with a DEFAULT_LCD_CHARSET it fails to compile
> with the following error message:
> drivers/staging/panel/panel.c: In function >>lcd_init<<:
> drivers/staging/panel/panel.c:1396: error: expected expression before
> >>;<< token
> drivers/staging/panel/panel.c:1475: error: expected expression before
> >>;<< token
> make[3]: *** [drivers/staging/panel/panel.o] error 1
> make[2]: *** [drivers/staging/panel] error 2
> make[1]: *** [drivers/staging] error 2
(...)
> #ifdef CONFIG_PANEL_LCD_CHARSET
> #undef DEFAULT_LCD_CHARSET
> -#define DEFAULT_LCD_CHARSET
> +#define DEFAULT_LCD_CHARSET CONFIG_PANEL_LCD_CHARSET
> #endif
Wow! I don't understand how this managed to slip through the various
tests for that long. That code is the the same in my 2.4 driver too,
so that means it has never worked for the last 5 years !
Obvious ACK from me, but please take a quick look at the place
where this define is used to ensure that any expected setting of
CONFIG_PANEL_LCD_CHARSET will not result in some other cryptic
error messages being sent to the user.
Thanks!
Willy
prev parent reply other threads:[~2009-12-15 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 5:21 Peter Huewe
2009-12-15 21:19 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215211953.GE11857@1wt.eu \
--to=w@1wt.eu \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=lcostantino@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sudhakar.raj@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®