From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934810AbZLPIUl (ORCPT ); Wed, 16 Dec 2009 03:20:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934760AbZLPIUd (ORCPT ); Wed, 16 Dec 2009 03:20:33 -0500 Received: from mail-pw0-f42.google.com ([209.85.160.42]:53023 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934787AbZLPIUZ (ORCPT ); Wed, 16 Dec 2009 03:20:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Au7FBXcUWEFNygqHwG5h5MrxookB5GUI1Kkf4DtnteQ6Qm5xPikTCyqU6pxRPQjBfn Nftu3+u1G1cM4VDwmylsNc6BXG8U3F/mAhGNkfkvN81OVZSE7Y5ooI2dm7HAWpDLWKqn eLdzbUT2oa8eT/YMTMDtCjGwoW229Vvh/uHeM= Date: Wed, 16 Dec 2009 00:20:20 -0800 From: Dmitry Torokhov To: Takashi Iwai Cc: Alex Chiang , linux-kernel , linux-input@vger.kernel.org Subject: Re: synaptics touchpad doesn't click Message-ID: <20091216082020.GG2699@core.coreip.homeip.net> References: <20091215062628.GA12669@core.coreip.homeip.net> <20091215073358.GC12669@core.coreip.homeip.net> <20091215082518.GD12669@core.coreip.homeip.net> <20091216010506.GA26367@ldl.fc.hp.com> <20091216025934.GA2699@core.coreip.homeip.net> <20091216065200.GC20352@ldl.fc.hp.com> <20091216070343.GF2699@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2009 at 08:11:05AM +0100, Takashi Iwai wrote: > At Tue, 15 Dec 2009 23:03:43 -0800, > Dmitry Torokhov wrote: > > > > On Tue, Dec 15, 2009 at 11:52:00PM -0700, Alex Chiang wrote: > > > * Dmitry Torokhov : > > > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > > > * Dmitry Torokhov : > > > > > > > > > > > > The updated patch is below. > > > > > > > > > > > > -- > > > > > > Dmitry > > > > > > > > > > Should I test this one or wait one more iteration to address > > > > > Takashi's last comments? > > > > > > > > > > > > > Actually I think we took the wrong direction with the original patch and > > > > we should do what other buttonless devices (bcm5974) do: report touchpad > > > > click as left button and have Synaptics X driver provide enhanced > > > > support. This way we can have both modes (ClickZones and ClickButtons) > > > > and users will get to chose (provided that someone takes time to add > > > > that support to Synaptics driver of course ;) ). > > > > > > > > Could you tell me if the below works for you? > > > > > > Left clicks work. Right/middle do not (as expected, I guess). > > > > > > I liked the behaviour of Takashi's patch a little better wrt what > > > happens when you try to click/drag, because he disabled movement > > > in the click area. > > > > Are the clicks register only in that special area? Reading Synaptics > > product description it sounds like entire surface should be clickable. > > In the case of ClickZone, the click in the button area is taken as > clicks, if I understand correctly. > > The problem is, however, not about where to click. It's about the > precision. When you click a pad, your finger slips a little bit in > millimeter. This already corresponds to a few pixels, and the pointer > moves away from the point you wanted to click. > Right, this will have to be dealt with in X driver. > In my original patch, I disabled the pointer movement in the button > area before click for avoiding this problem. > However it will not work if you want to do 'ClickButtons' mode where you don't assign secific areas for clicking. -- Dmitry