From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: torvalds@linux-foundation.org, h-shimamoto@ct.jp.nec.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: revert "config FS_JOURNAL_INFO"
Date: Thu, 17 Dec 2009 12:09:20 -0800 [thread overview]
Message-ID: <20091217120920.7521d1f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <b6fcc0a0912170031u162b7f56kf9f6adc23e24278c@mail.gmail.com>
On Thu, 17 Dec 2009 10:31:52 +0200
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Can we please revert commit e4c570c4cb7a95dbfafa3d016d2739bf3fdfe319
> "task_struct: make journal_info conditional"
>
> I think I gave a good enough arguments to not merge it.
> To iterate:
> * patch makes impossible to start using ext3 on EXT3_FS=n kernels
> without reboot.
> * this is done only for one pointer on task_struct
>
> None of config options which define task_struct are tristate directly
> or effectively.
>
> There are other examples where we don't do this:
> * quota stuff on superblock aren't ifdeffed because of modular XFS
> with quota support.
> * exports operations and s_anon for NFS
> and so on
Confused. I "dropped" that patch when you pointed out the problem then
forgot about it.
Maybe I dropped something else by accident. argh.
I agree - I'll queue a revert.
next prev parent reply other threads:[~2009-12-17 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 8:31 Alexey Dobriyan
2009-12-17 20:09 ` Andrew Morton [this message]
2009-12-18 4:04 ` Hiroshi Shimamoto
2009-12-18 7:25 ` Alexey Dobriyan
2009-12-18 7:48 ` Hiroshi Shimamoto
2009-12-19 11:51 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217120920.7521d1f3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome