From: Jean Delvare <khali@linux-fr.org>
To: roger blofeld <blofeldus@yahoo.com>
Cc: "Darrick J. Wong" <djwong@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] adt7462: Fix pin 28 monitoring
Date: Thu, 17 Dec 2009 16:10:09 +0100 [thread overview]
Message-ID: <20091217161009.3a3a106f@hyperion.delvare> (raw)
In-Reply-To: <994.13667.qm@web53501.mail.re2.yahoo.com>
Hi Roger,
On Fri, 11 Dec 2009 18:54:54 -0800 (PST), roger blofeld wrote:
> The ADT7462_PIN28_VOLT value is a 4-bit field, so the corresponding shift must be 4.
>
> Signed-off-by: Roger Blofeld <blofeldus@yahoo.com>
> ---
> My mailer will whitespace damage the inline copy of the patch.
> The attached version should be OK.
>
> diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c
> index 1852f27..262c133 100644
> --- a/drivers/hwmon/adt7462.c
> +++ b/drivers/hwmon/adt7462.c
> @@ -97,7 +97,7 @@ I2C_CLIENT_INSMOD_1(adt7462);
> #define ADT7462_PIN24_SHIFT 6
> #define ADT7462_PIN26_VOLT_INPUT 0x08
> #define ADT7462_PIN25_VOLT_INPUT 0x20
> -#define ADT7462_PIN28_SHIFT 6 /* cfg3 */
> +#define ADT7462_PIN28_SHIFT 4 /* cfg3 */
> #define ADT7462_PIN28_VOLT 0x5
>
> #define ADT7462_REG_ALARM1 0xB8
Correct. Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2009-12-17 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 2:54 roger blofeld
2009-12-17 15:10 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217161009.3a3a106f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=blofeldus@yahoo.com \
--cc=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome