From: David Miller <davem@davemloft.net>
To: jesse.brandeburg@intel.com
Cc: roger.oksanen@cs.helsinki.fi, stern@rowland.harvard.edu,
jeffrey.t.kirsher@intel.com, bruce.w.allan@intel.com,
peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com,
e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: e100 REGRESSION in 2.6.32 (PATCH v2)
Date: Fri, 18 Dec 2009 20:19:14 -0800 (PST) [thread overview]
Message-ID: <20091218.201914.102544489.davem@davemloft.net> (raw)
In-Reply-To: <alpine.WNT.2.00.0912170919010.2612@jbrandeb-desk1.amr.corp.intel.com>
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Date: Thu, 17 Dec 2009 09:21:49 -0800 (Pacific Standard Time)
>
> On Thu, 17 Dec 2009, Roger Oksanen wrote:
>> e100: Fix broken cbs accounting due to missing memset.
>>
>> Alan Stern noticed that e100 caused slab corruption.
>> commit 98468efddb101f8a29af974101c17ba513b07be1 changed
>> the allocation of cbs to use dma pools that don't return zeroed memory,
>> especially the cb->status field used to track which cb to clean, causing
>> (the visible) double freeing of skbs and a wrong free cbs count.
>>
>> Now the cbs are explicitly zeroed at allocation time.
>>
>> Reported-by: Alan Stern <stern@rowland.harvard.edu>
>> Tested-by: Alan Stern <stern@rowland.harvard.edu>
>> Signed-off-by: Roger Oksanen <roger.oksanen@cs.helsinki.fi>
>
> Change looks reasonable, ACK.
Applied, thanks everyone. I'll try to requeue the e100 stuff
together into -stable again now that this is resolved.
> should we also consider a followon patch to zero memory allocated with
> pci_pools? Seems useful.
Nah, it's more fun debugging subtle bugs like this one.
:-)
prev parent reply other threads:[~2009-12-19 4:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 22:17 e100 REGRESSION in 2.6.32 Alan Stern
2009-12-16 18:21 ` Brandeburg, Jesse
2009-12-16 19:11 ` David Miller
2009-12-16 19:50 ` Alan Stern
2009-12-16 20:46 ` Roger Oksanen
2009-12-17 12:14 ` e100 REGRESSION in 2.6.32 (PATCH) Roger Oksanen
2009-12-17 15:47 ` Alan Stern
2009-12-17 16:10 ` e100 REGRESSION in 2.6.32 (PATCH v2) Roger Oksanen
2009-12-17 17:21 ` Brandeburg, Jesse
2009-12-17 21:15 ` Laurent Chavey
2009-12-19 4:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218.201914.102544489.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=roger.oksanen@cs.helsinki.fi \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®