From: Simon Horman <horms@verge.net.au>
To: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [patch] rtl8192su: Build should select WIRELESS_EXT
Date: Mon, 21 Dec 2009 15:07:10 +1100 [thread overview]
Message-ID: <20091221040710.GA22636@verge.net.au> (raw)
The prevailing idiom is to select WIRELESS_EXT not depend on it.
Depending leaves this driver in a situation where it can only
be built if another driver that selects WIRELESS_EXT has been enabled.
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: net-next-2.6/drivers/staging/rtl8192su/Kconfig
===================================================================
--- net-next-2.6.orig/drivers/staging/rtl8192su/Kconfig 2009-12-21 11:59:46.000000000 +1100
+++ net-next-2.6/drivers/staging/rtl8192su/Kconfig 2009-12-21 12:02:35.000000000 +1100
@@ -1,6 +1,7 @@
config RTL8192SU
tristate "RealTek RTL8192SU Wireless LAN NIC driver"
depends on PCI && WLAN && USB
- depends on WIRELESS_EXT
+ select WIRELESS_EXT
+ select WEXT_PRIV
default N
---help---
reply other threads:[~2009-12-21 4:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221040710.GA22636@verge.net.au \
--to=horms@verge.net.au \
--cc=bzolnier@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®