From: Ingo Molnar <mingo@elte.hu>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Arjan van de Ven <arjan@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Ritesh Raj Sarraf <rrs@researchut.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.33-rc1 build failure: copy_from_user() buffer size is not provably correct
Date: Mon, 21 Dec 2009 10:13:30 +0100 [thread overview]
Message-ID: <20091221091330.GA22867@elte.hu> (raw)
In-Reply-To: <20091221180537.089C.A69D9226@jp.fujitsu.com>
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > This is triggered if using the 'allyesconfig' target.
> >
> > A similar issue was this: 2886a8bdfa007053b414ab01741a98c18c376a85
> >
> >
> > debian-build:/tmp/all-yes-config/2.6.33-rc1# make deb-pkg
> > make KBUILD_SRC=
> > CHK include/linux/version.h
> > CHK include/generated/utsrelease.h
> > CALL scripts/checksyscalls.sh
> > CHK include/generated/compile.h
> > VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
> > VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
> > VDSOSYM arch/x86/vdso/vdso32-syms.lds
> > LD arch/x86/vdso/built-in.o
> > LD arch/x86/built-in.o
> > CC mm/migrate.o
> > In file included from /tmp/all-yes-config/2.6.33-
> > rc1/arch/x86/include/asm/uaccess.h:571,
> > from include/linux/uaccess.h:5,
> > from include/linux/highmem.h:6,
> > from include/linux/pagemap.h:10,
> > from include/linux/mempolicy.h:62,
> > from include/linux/migrate.h:5,
> > from mm/migrate.c:15:
> > In function ???copy_from_user???,
> > inlined from ???do_pages_stat??? at mm/migrate.c:1009:
> > /tmp/all-yes-config/2.6.33-rc1/arch/x86/include/asm/uaccess_32.h:213: error:
> > call to ???copy_from_user_overflow??? declared with attribute error:
> > copy_from_user() buffer size is not provably correct
>
> afaik, ingo already queued this fix.
> please wait (very) few days.
>
> thanks.
hm, the one mm/migrate.c fix we had is already in -rc1:
b9255850: mm: Adjust do_pages_stat() so gcc can see copy_from_user() is safe
I've Cc:-ed more folks.
Ingo
next prev parent reply other threads:[~2009-12-21 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 8:34 Ritesh Raj Sarraf
2009-12-21 9:07 ` KOSAKI Motohiro
2009-12-21 9:13 ` Ingo Molnar [this message]
2009-12-21 11:09 ` Ritesh Raj Sarraf
2009-12-21 17:18 ` H. Peter Anvin
2009-12-21 17:27 ` Arjan van de Ven
2009-12-21 17:17 ` H. Peter Anvin
2009-12-21 17:42 ` Ritesh Raj Sarraf
2009-12-22 0:19 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221091330.GA22867@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rrs@researchut.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®