Re: [RFC PATCH] dynamic debug - adding ring buffer storage support

[Jiri Olsa <jolsa@redhat.com>]

On Tue, Dec 22, 2009 at 01:06:06PM +0100, Andi Kleen wrote:
> Jiri Olsa <jolsa@redhat.com> writes:
> 
> > Hi,
> >
> > as I use dynamic debug sometimes, I thought it could be useful having
> > the possibility to store the output somewhere else than dmesg.
> >
> > The attached patch implements support for storing dynamic debug
> > messages to the ring buffer.
> >
> > The dynamic debug allows simple addition of new flags,
> > so I added 'r' flag for ring buffer storage.
> >
> > I used the ring buffer implementation from trace framework.
> >
> > hopefuly this could be any use for others as well...
> > plz let me know what you think,
> 
> The basic idea sounds good, but doing it all inline is a horrible 
> idea. That will bloat the kernel considerably because all
> users have to expand this code.
> 
> I would suggest to implement an out of line dyndebug_printk()
> which does all of this out of line.

right, I'll try to squeeze it

thanks,
jirka

> 
> -Andi
> -- 
> ak@linux.intel.com -- Speaking for myself only.