From: Simon Horman <horms@verge.net.au>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 7/7] [patch] rtl8192u: Clarify logic in‘ieee80211_wx_get_encode_ext_rsl()
Date: Wed, 23 Dec 2009 21:39:37 +1100 [thread overview]
Message-ID: <20091223103933.GA16537@verge.net.au> (raw)
In-Reply-To: <20091223085553.648368336@vergenet.net>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
I think this is what is meant.
Compile tested only.
$ gcc --version
gcc (Debian 4.4.2-6) 4.4.2
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ make CONFIG_DEBUG_SECTION_MISMATCH=y
...
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c: In function ‘ieee80211_wx_get_encode_ext_rsl’:
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c:721: warning: suggest parentheses around operand of ‘!’ or change ‘&’ to ‘&&’ or ‘!’ to ‘~’
...
[ Trying again as vger didn't like the headers the first time around ]
Index: gregkh-2.6/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
===================================================================
--- gregkh-2.6.orig/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c 2009-12-23 19:14:41.000000000 +1100
+++ gregkh-2.6/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c 2009-12-23 19:14:44.000000000 +1100
@@ -718,7 +718,7 @@ int ieee80211_wx_get_encode_ext(struct i
} else
idx = ieee->tx_keyidx;
- if (!ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY &&
+ if (!(ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY) &&
ext->alg != IW_ENCODE_ALG_WEP)
if (idx != 0 || ieee->iw_mode != IW_MODE_INFRA)
return -EINVAL;
prev parent reply other threads:[~2009-12-23 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 8:54 [patch 0/7] minor cleanups for various staging drivers Simon Horman
2009-12-23 8:54 ` [patch 1/7] [patch] DT3155: Use pci_get_device Simon Horman
2009-12-23 16:19 ` Greg KH
2009-12-23 22:02 ` Simon Horman
2009-12-23 23:37 ` Greg KH
2009-12-24 2:11 ` Simon Horman
2009-12-23 8:54 ` [patch 2/7] [patch] rt2870: rtusb_probe() should be in section __devinit Simon Horman
2009-12-23 8:54 ` [patch 3/7] [patch] rt2870: Remove unnecessary forward declarations Simon Horman
2009-12-23 8:54 ` [patch 4/7] [patch] rtl8192e: print the elements of tx_pn and rx_pn not the arrays themselves Simon Horman
2009-12-23 8:54 ` [patch 5/7] [patch] rtl8192e: remove some functions from the __exit section Simon Horman
2009-12-23 8:54 ` [patch 6/7] [patch] rtl8192su, rtl8192u: use min_t() in store_debug_level() Simon Horman
[not found] ` <20091223085553.648368336@vergenet.net>
2009-12-23 10:39 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223103933.GA16537@verge.net.au \
--to=horms@verge.net.au \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®