mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <petkovbb@googlemail.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/get_maintainer.pl: add support to read patch from STDIN
Date: Thu, 24 Dec 2009 07:45:56 +0100	[thread overview]
Message-ID: <20091224064556.GA26621@liondog.tnic> (raw)
In-Reply-To: <1261610824.1923.58.camel@Joe-Laptop.home>

On Wed, Dec 23, 2009 at 03:27:04PM -0800, Joe Perches wrote:
> On Wed, 2009-12-23 at 14:55 +0100, Borislav Petkov wrote:
> > Teach get_maintainer.pl to read a diff from STDIN
> 
> How about this instead?
> 
> Doesn't need or accept '-' as a trailing option to read stdin.
> Doesn't print usage() after bad options.
> Adds --usage as command line equivalent of --help

This breaks current usage and possibly other scripts:

# git diff | ./scripts/get_maintainer.pl -
./scripts/get_maintainer.pl: file '-' not found

Just do it as it is done at http://lkml.indiana.edu/hypermail/linux/kernel/0801.1/1654.html

-- 
Regards/Gruss,
    Boris.

  reply	other threads:[~2009-12-24  6:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 13:55 [PATCH] scripts/get_maintainer.pl: add support for STDIN: Borislav Petkov
2009-12-23 23:27 ` [PATCH] scripts/get_maintainer.pl: add support to read patch from STDIN Joe Perches
2009-12-24  6:45   ` Borislav Petkov [this message]
2009-12-24  6:48     ` Joe Perches
2009-12-24  6:53     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091224064556.GA26621@liondog.tnic \
    --to=petkovbb@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®