From: Shaohua Li <shaohua.li@intel.com>
To: linux-kernel@vger.kernel.org
Cc: jens.axboe@oracle.com, czoccolo@gmail.com, yanmin.zhang@intel.com
Subject: [RFC]cfq-iosched: quantum check tweak
Date: Fri, 25 Dec 2009 17:10:30 +0800 [thread overview]
Message-ID: <20091225091030.GA28365@sli10-desk.sh.intel.com> (raw)
Currently a queue can only dispatch up to 4 requests if there are other queues.
This isn't optimal, device can handle more requests, for example, AHCI can
handle 31 requests. I can understand the limit is for fairness, but we could
do some tweaks:
1. if the queue still has a lot of slice left, sounds we could ignore the limit
2. we could keep the check only when cfq_latency is on. For uses who don't care
about latency should be happy to have device fully piped on.
I have a test of random direct io of two threads, each has 32 requests one time
without patch: 78m/s
with tweak 1: 138m/s
with two tweaks and disable latency: 156m/s
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
block/cfq-iosched.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: linux-2.6/block/cfq-iosched.c
===================================================================
--- linux-2.6.orig/block/cfq-iosched.c
+++ linux-2.6/block/cfq-iosched.c
@@ -2242,6 +2242,18 @@ static int cfq_forced_dispatch(struct cf
return dispatched;
}
+static inline bool cfq_slice_used_soon(struct cfq_data *cfqd,
+ struct cfq_queue *cfqq)
+{
+ /* the queue hasn't finished any request, can't estimate */
+ if (cfq_cfqq_slice_new(cfqq))
+ return 1;
+ if (time_after(jiffies + cfqd->cfq_slice_idle, cfqq->slice_end))
+ return 1;
+
+ return 0;
+}
+
static bool cfq_may_dispatch(struct cfq_data *cfqd, struct cfq_queue *cfqq)
{
unsigned int max_dispatch;
@@ -2275,7 +2287,8 @@ static bool cfq_may_dispatch(struct cfq_
/*
* We have other queues, don't allow more IO from this one
*/
- if (cfqd->busy_queues > 1)
+ if (cfqd->busy_queues > 1 && cfq_slice_used_soon(cfqd, cfqq)
+ && cfqd->cfq_latency)
return false;
/*
next reply other threads:[~2009-12-25 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-25 9:10 Shaohua Li [this message]
2009-12-25 9:44 ` Corrado Zoccolo
2009-12-28 3:35 ` Shaohua Li
2009-12-28 9:02 ` Corrado Zoccolo
2010-01-07 2:04 ` Shaohua Li
2010-01-07 21:44 ` Corrado Zoccolo
2010-01-08 0:57 ` Shaohua Li
2010-01-08 20:22 ` Corrado Zoccolo
2010-01-11 1:49 ` Shaohua Li
2010-01-11 2:01 ` Shaohua Li
2010-01-08 17:15 ` Vivek Goyal
2010-01-08 17:40 ` Vivek Goyal
2010-01-08 20:35 ` Corrado Zoccolo
2010-01-08 20:59 ` Vivek Goyal
2010-01-11 2:34 ` Shaohua Li
2010-01-11 17:03 ` Vivek Goyal
2010-01-12 3:07 ` Shaohua Li
2010-01-12 15:48 ` Vivek Goyal
2010-01-13 8:17 ` Shaohua Li
2010-01-13 11:18 ` Vivek Goyal
2010-01-14 4:16 ` Shaohua Li
2010-01-14 11:31 ` Vivek Goyal
2010-01-14 13:49 ` Jens Axboe
2010-01-15 3:20 ` Li, Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225091030.GA28365@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=czoccolo@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®