From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Takashi Iwai <tiwai@suse.de>
Cc: Len Brown <len.brown@intel.com>, Amerigo Wang <amwang@redhat.com>,
Corentin Chary <corentincj@iksaif.net>,
Marcel Holtmann <marcel@holtmann.org>,
linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
Randy Dunlap <rdunlap@xenotime.net>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
helight.xu@gmail.com, Xiaotian Feng <xtfeng@gmail.com>,
akpm@linux-foundation.org
Subject: Re: [ibm-acpi-devel] [Patch] thinkpad_acpi: fix a build error
Date: Fri, 25 Dec 2009 11:41:57 -0200 [thread overview]
Message-ID: <20091225134157.GC5891@khazad-dum.debian.net> (raw)
In-Reply-To: <s5h8wcrmhsn.wl%tiwai@suse.de>
On Fri, 25 Dec 2009, Takashi Iwai wrote:
> > "depends on SND || SND = n" takes care of the technical restrictions.
>
> Yep, that's what I mentioned as Kconfig dependency :)
I think I will do it a bit different, so that you can opt-out ALSA support
and still have thinkpad-acpi built in, with modular ALSA in that case.
Which means that, due to the lack of "depends-but-not-hide", the
"thinkpad-acpi alsa support" kconfig entry will still just disappear due to
a "depends on SND && SND = THINKPAD_ACPI".
I really want a depends that leaves the entry still visible, but greyed out
:-(
> > The warning will be there. Although I don't warn of missing rfkill
> > functionality if the kernel is missing the rfkill subsystem...
>
> The messages could be KERN_INFO instead of KERN_WARNING, I think.
It is at KERN_NOTICE right now.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-12-25 13:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 9:28 Amerigo Wang
2009-12-18 9:42 ` Xiaotian Feng
2009-12-18 10:15 ` Takashi Iwai
2009-12-18 12:23 ` Helight.Xu
2009-12-18 14:28 ` Henrique de Moraes Holschuh
2009-12-18 14:31 ` Takashi Iwai
2009-12-18 15:03 ` Henrique de Moraes Holschuh
2009-12-18 15:10 ` Takashi Iwai
2009-12-21 22:38 ` Marcel Holtmann
2009-12-21 22:44 ` Randy Dunlap
2009-12-22 19:38 ` Henrique de Moraes Holschuh
2009-12-23 6:41 ` Takashi Iwai
2009-12-24 18:59 ` Henrique de Moraes Holschuh
2009-12-25 11:09 ` Takashi Iwai
2009-12-25 13:41 ` Henrique de Moraes Holschuh [this message]
2009-12-25 18:39 ` [ibm-acpi-devel] " Randy Dunlap
2009-12-22 1:10 ` Helight.Xu
2009-12-22 3:00 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225134157.GC5891@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=akpm@linux-foundation.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=amwang@redhat.com \
--cc=corentincj@iksaif.net \
--cc=helight.xu@gmail.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rdunlap@xenotime.net \
--cc=tiwai@suse.de \
--cc=xtfeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®