From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Joe Perches <joe@perches.com>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Len Brown <len.brown@intel.com>,
ibm-acpi-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thinkpad_acpi.c: Remove #define TPACPI_<level>s for printks
Date: Sat, 26 Dec 2009 22:29:35 -0200 [thread overview]
Message-ID: <20091227002935.GC26593@khazad-dum.debian.net> (raw)
In-Reply-To: <1261802563.2568.75.camel@Joe-Laptop.home>
On Fri, 25 Dec 2009, Joe Perches wrote:
> On Sat, 2009-12-26 at 02:20 -0200, Henrique de Moraes Holschuh wrote:
> > Why would I want a parameter macro instead of a straightforward bunch of
> > #defines ?
>
> To make grep a bit easier.
Is greping for KERN_<priority> common?
Unfolding the printk messages to a single line _is_ useful for grep, though,
and I plan to do just that (not high priority, though), and I would accept
patches that do just that without any fuss :)
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-12-27 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 3:23 Joe Perches
2009-12-26 4:20 ` Henrique de Moraes Holschuh
2009-12-26 4:42 ` Joe Perches
2009-12-27 0:29 ` Henrique de Moraes Holschuh [this message]
2009-12-27 1:07 ` Joe Perches
2009-12-27 1:10 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091227002935.GC26593@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®