mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Blum <bblum@andrew.cmu.edu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, akpm@linux-foundation.org,
	Paul Menage <menage@google.com>,
	bblum@andrew.cmu.edu
Subject: Re: [PATCH 2/4] cgroups: subsystem module loading interface
Date: Mon, 28 Dec 2009 07:40:30 -0500	[thread overview]
Message-ID: <20091228124029.GB4824@andrew.cmu.edu> (raw)
In-Reply-To: <4B3850F4.4090203@cn.fujitsu.com>

On Mon, Dec 28, 2009 at 02:32:20PM +0800, Li Zefan wrote:
> > Add interface between cgroups subsystem management and module loading
> > 
> > From: Ben Blum <bblum@andrew.cmu.edu>
> > 
> > This patch implements rudimentary module-loading support for cgroups - namely,
> > a cgroup_load_subsys (similar to cgroup_init_subsys) for use as a module
> > initcall, and a struct module pointer in struct cgroup_subsys.
> > 
> > Several functions that might be wanted by modules have had EXPORT_SYMBOL added
> > to them, but it's unclear exactly which functions want it and which won't.
> > 
> > Signed-off-by: Ben Blum <bblum@andrew.cmu.edu>
> 
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> Some small nitpicks:
> 
> > --- a/kernel/cgroup.c
> > +++ b/kernel/cgroup.c
> > @@ -2477,6 +2477,7 @@ int cgroup_add_file(struct cgroup *cgrp,
> >  		error = PTR_ERR(dentry);
> >  	return error;
> >  }
> > +EXPORT_SYMBOL_GPL(cgroup_add_file);
> 
> I got compile errors, because you forgot to include <linux/module.h>
> 
> ...
> > +	write_lock(&css_set_lock);
> > +	for (i = 0; i < CSS_SET_TABLE_SIZE; i++) {
> > +		struct css_set *cg;
> > +		struct hlist_node *node, *tmp;
> > +		struct hlist_head *bucket = &css_set_table[i], *new_bucket;
> 
> Please add a blank line between variable declaration and other code.
> 
> And elsewhere in this patchset.
> 

checkpatch.pl didn't trip on this [and the more screenspace-intensive
comment style]; are they cgroups-specific style requirements or from
somewhere higher up?

> > +		hlist_for_each_entry_safe(cg, node, tmp, bucket, hlist) {
> > +			/* skip entries that we already rehashed */
> > +			if (cg->subsys[ss->subsys_id])
> > +				continue;
> > +			/* remove existing entry */
> > +			hlist_del(&cg->hlist);
> > +			/* set new value */
> > +			cg->subsys[ss->subsys_id] = css;
> > +			/* recompute hash and restore entry */
> > +			new_bucket = css_set_hash(cg->subsys);
> > +			hlist_add_head(&cg->hlist, new_bucket);
> > +		}
> > +	}
> > +	write_unlock(&css_set_lock);
> 
> 
> 

  reply	other threads:[~2009-12-28 12:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 20:32 [PATCH 0/4] cgroups: support for module-loadable subsystems Ben Blum
2009-12-21 20:35 ` [PATCH 1/4] cgroups: revamp subsys array Ben Blum
2009-12-28  6:29   ` Li Zefan
2009-12-21 20:36 ` [PATCH 2/4] cgroups: subsystem module loading interface Ben Blum
2009-12-28  6:32   ` Li Zefan
2009-12-28 12:40     ` Ben Blum [this message]
2009-12-29  1:03       ` Li Zefan
2009-12-21 20:37 ` [PATCH 3/4] cgroups: net_cls as module Ben Blum
2009-12-28  6:34   ` Li Zefan
2009-12-28 12:37     ` Ben Blum
2009-12-21 20:38 ` [PATCH 4/4] cgroups: subsystem module unloading Ben Blum
2009-12-28  6:36   ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091228124029.GB4824@andrew.cmu.edu \
    --to=bblum@andrew.cmu.edu \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®