mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hartleys@visionengravers.com
Cc: linux-kernel@vger.kernel.org, tom@opengridcomputing.com
Subject: Re: [PATCH] amso1100/c2_provider.c: use %pM to shown MAC address
Date: Wed, 30 Dec 2009 21:59:26 -0800 (PST)	[thread overview]
Message-ID: <20091230.215926.226788191.davem@davemloft.net> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090200F533@mi8nycmail19.Mi8.com>

From: "H Hartley Sweeten" <hartleys@visionengravers.com>
Date: Tue, 29 Dec 2009 11:22:42 -0500

> Use the %pM kernel extension to display the MAC address.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Hartley, I was going to mention this for your previous
series, and now that you've sent another huge set of
patches I must make a note of this.

Every single one of your patches applies with one-line of
patch 'fuzz', like this:

davem@sunset:~/src/GIT/linux-2.6$ patch -p1 <diff
patching file drivers/infiniband/hw/amso1100/c2_provider.c
Hunk #1 succeeded at 760 with fuzz 1.

And GIT rejects such patches entirely:

davem@sunset:~/src/GIT/linux-2.6$ git apply --check --whitespace=error-all diff
error: patch failed: drivers/infiniband/hw/amso1100/c2_provider.c:760
error: drivers/infiniband/hw/amso1100/c2_provider.c: patch does not apply

So I had to add all of your patches to my tree by hand, one by one,
yesterday.

I refuse to do this for so many more patches.  Could you generate
patches that apply accurately?

Thanks.

  reply	other threads:[~2009-12-31  5:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29 16:22 H Hartley Sweeten
2009-12-31  5:59 ` David Miller [this message]
2009-12-31 14:32   ` H Hartley Sweeten
2010-01-04  6:24     ` David Miller
2010-01-04 17:39       ` H Hartley Sweeten
2010-01-04 18:42         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091230.215926.226788191.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome