From: Greg KH <gregkh@suse.de>
To: Emese Revfy <re.emese@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org, rientjes@google.com,
cl@linux-foundation.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, rjw@sisk.pl, rusty@rustcorp.com.au,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/1] Constify struct kset_uevent_ops for 2.6.33-rc2
Date: Wed, 30 Dec 2009 20:40:39 -0800 [thread overview]
Message-ID: <20091231044039.GB27927@suse.de> (raw)
In-Reply-To: <4B3BED7A.6020507@gmail.com>
On Thu, Dec 31, 2009 at 01:16:58AM +0100, Emese Revfy wrote:
> Greg KH wrote:
> > On Tue, Dec 29, 2009 at 09:58:11PM +0100, Emese Revfy wrote:
> >>>> I double checked both the declaration and definitions of the affected
> >>>> function/structure and they are consistently const here.
> >>>> Can you tell me what patch/tree combination you encountered this
> >>>> warning with?
> >>> 2.6.33-rc2 with your patch.
> >> Here is the updated patch for 2.6.33-rc2 in one piece.
> >> Emese
> >>
> >>
> >> From: Emese Revfy <re.emese@gmail.com>
> >>
> >> Constify struct kset_uevent_ops.
> >
> > Why is this needed? What does it accomplish?
>
> This is my contribution to the ops structure constification effort
> that some developers started a few years ago (Arjan, Al Viro, etc.)
> and that has been worked on somewhat sporadically ever since. For a
> summary of why this is useful please see Arjan's email:
> http://lkml.org/lkml/2009/12/14/216
Then please insert this kind of information in the patch itself,
otherwise it is totally unknown.
Care to resend with the proper information in it?
thanks,
greg k-h
next prev parent reply other threads:[~2009-12-31 4:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 0:00 [PATCH 0/4] Constify struct kset_uevent_ops for 2.6.32-git-053fe57ac v2 re.emese
2009-12-14 0:00 ` [PATCH 1/4] " re.emese
2009-12-14 0:00 ` [PATCH 2/4] " re.emese
2009-12-14 10:22 ` Steven Whitehouse
2009-12-14 0:00 ` [PATCH 1/1] Constify struct kgdb_io " re.emese
2009-12-14 0:00 ` [PATCH 3/4] Constify struct kset_uevent_ops " re.emese
2009-12-25 11:31 ` Pekka Enberg
2009-12-26 0:38 ` Emese Revfy
2009-12-28 20:46 ` David Rientjes
2009-12-29 20:50 ` Emese Revfy
2009-12-29 20:51 ` Pekka Enberg
2009-12-29 7:24 ` Pekka Enberg
2009-12-29 20:58 ` [PATCH 1/1] Constify struct kset_uevent_ops for 2.6.33-rc2 Emese Revfy
2009-12-30 0:11 ` Greg KH
2009-12-31 0:16 ` Emese Revfy
2009-12-31 4:40 ` Greg KH [this message]
2009-12-31 13:52 ` Emese Revfy
2009-12-14 0:00 ` [PATCH 4/4] Constify struct kset_uevent_ops for 2.6.32-git-053fe57ac v2 re.emese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091231044039.GB27927@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=re.emese@gmail.com \
--cc=rientjes@google.com \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®