From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
Date: Thu, 7 Apr 2022 23:06:24 +0200 [thread overview]
Message-ID: <200a2002-8573-efaa-774a-51dcec9cc807@linaro.org> (raw)
In-Reply-To: <Yk8rpUXmfmULMVjr@robh.at.kernel.org>
On 07/04/2022 20:21, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
>> After conversion the jedec,spi-nor DT schema to reference other schemas
>> (SPI and MTD) and use unevaluatedProperties, several properties are
>> redundant.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../devicetree/bindings/mtd/jedec,spi-nor.yaml | 11 -----------
>> 1 file changed, 11 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index 4abfb4cfc157..708e7f88fd92 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -50,10 +50,6 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> - spi-max-frequency: true
>> - spi-rx-bus-width: true
>> - spi-tx-bus-width: true
>> -
>> m25p,fast-read:
>> type: boolean
>> description:
>> @@ -74,14 +70,9 @@ properties:
>> be used on such systems, to denote the absence of a reliable reset
>> mechanism.
>>
>> - label: true
>> -
>> partitions:
>> type: object
>>
>> - '#address-cells': true
>> - '#size-cells': true
>
> These are needed for 'partition' nodes.
>
I am sure I saw them in one of referenced schemas, that's why I removed
them. But now I cannot find it so probably I looked at wrong schema.
Thanks for pointing this out, I'll fix the patch.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-04-07 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:20 Krzysztof Kozlowski
2022-04-07 18:09 ` Pratyush Yadav
2022-04-07 18:21 ` Rob Herring
2022-04-07 21:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200a2002-8573-efaa-774a-51dcec9cc807@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®