From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5137D38F24C for ; Fri, 6 Feb 2026 10:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770375184; cv=none; b=EMs/d2MVYW24NilSAPnLCWOPLqmwV4EA0X31QaAX83MFmsNEcgLEX5UgWo/2znFzxhvQZ/XC4DaxERTnAlRbJMdNODp38+bN04t9jg7Jm/ulsFXcwBiDCGliACkSpYU9WuvcDf4auwNPzQ9Q3dsqVbKT+3zmlPalhzjDDgvIXd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770375184; c=relaxed/simple; bh=uxm14t0B6nm9R1dm/Th4VVVwCqQPzmPMt7T8m8GJ1WA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I4oCgtxSbaWodEEky7sYPrT3LSz4Fpt+oY+ZJHCZPfq8FPinVSJUruxnJFoXlDn9gW0KSVWDi/qVgI9ne9hqZD2h80S1qgKGuKBKziAkkOx5sG9jNjZywKxmD+tGySmdR0iu10i3GEgvWzMgIYNOSVI8PAtTjaua8sKhI0aoyFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PZOxhGmn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iZnZsAIc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PZOxhGmn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iZnZsAIc" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6167Xiwp1852754 for ; Fri, 6 Feb 2026 10:53:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l3AHMbFXpk+dKoC4YLpaH+pl/OddhSfAMGUwFFGZjyI=; b=PZOxhGmnhjfXx6s7 yWW31Wy1ZyWnJNJa6u4hqaYk509KHn79ZSfhmPNPvjBvbgO5CoiAJhmo0IW9SLVz i+9kBFKHJDdmDVIvrbs8SJdkyu+fdnCrT+YXj1Pio506AVlQUlftlcO4+PHqZnna BjhP1NXZX5pQVZs9tWd4lzW4DSwSOpRrKAFBkOj6AUcj7yFEK8Loz/aswkjt0RAY MhBCFDerGWKThqCTpmhHZMSv20WgFMICYoiMuOHyAvttMn+lp26dPGaHoKUAatUc l0rhW2sYIIa83Q3WCvqr0eG278ph0Hff7le0dV0rtB7njiYb+I9fcuB5thQh+pIs tp0hhg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5c148mfm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 10:53:03 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8946ebb51a0so7085656d6.0 for ; Fri, 06 Feb 2026 02:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770375182; x=1770979982; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l3AHMbFXpk+dKoC4YLpaH+pl/OddhSfAMGUwFFGZjyI=; b=iZnZsAIcjQNbeMBz7gI8/F+hPwOrNMNZ8k6XUe6ZJiKGdSH6LRcqtJoXGf2kAMgrfW YRAu8sTBrB1tSbu05h9MFEVoNHGWHCneGGX2Nq9d4AJwvgaeIGJ9xWeLXHaFSI3j3BIs TufeftvUVxKgliYSQSWmgjrjbbCW4pAf47dI27BtAt4tfPGJuw5YWiEvaUX7HKENinLs 0zTRBNb3Y1AO0DI+H9ecFcTojxZkEcLO4LwUrJQvJf5JN+AtSplO3d/l17nBnXR8haNp yxflTW8NROeCCoqceoiaQGJ/0RMX+rvotpq0x2tveg6d7fbkW4mDBs6ZU3vc3Uuz6gRZ 7log== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770375182; x=1770979982; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l3AHMbFXpk+dKoC4YLpaH+pl/OddhSfAMGUwFFGZjyI=; b=Y4L7pXWcpK8gmyOTvuR7oFBEDjTRYXC1VXei0a6VeT5QSRk7XBZZJAPWkhF5k254ZT /Uu6nHYoC67YHzbKDGygdTe42kEYNHs3yT4nFUxRuImmUSImmsnNKW9LbgHR4hzWwPTu gcLUzVZ+ClSTlc8NSw44o647DvMpHfGxj/3xBht0tHWgBYS5LjMr7/qYjBuIqAxQmoEB 8h8P61uu5vWjpv1/5hn1LjAEWbU9aslzGPLFC8sC89pE2GeohFpkuJLm/NWIsBSUi7XP NrMpmzwHM79pG78FHMs54aXFjLsU3xIgyuDMO6+v3rHG1WfF07Fuj7W7m4AoNCdaS2vU MwRA== X-Forwarded-Encrypted: i=1; AJvYcCWf12cKCcienAwUHzp1K9gJFBeKmh/w/+VCNFCnVqpNf51zFvA8bf37bnuZA7TS2aVVS9eU/7643VbmKQM=@vger.kernel.org X-Gm-Message-State: AOJu0YyGGwpwkCiwmPGXsy55aK/mw3RXK+gryUBGuQXUdePgqXT5RCNl lKfocESlrtJ+WVlDZ78O7Le6cAZWL7/SsHmCFzUDWmos28lYAHpm4/d1u15YvVqX3mZH6KyG7c3 rcyJRMnsGeMK/snVLz6f+9b6a1vJJJLImVNVto9jIhPZ1GHii4X9/P35KvXc3OyejhNQ= X-Gm-Gg: AZuq6aIlnMVxhYBRjZ7YyubdLPUfjeQoMeE26lvFZOLB2AjTKBbxDNe77N6Kw5m5kP6 6VX/1NvBKbhBhidwQlG36hEfjMiARwfoFDAjX6kv3UDIV/UgX4IXJvo4Rsi8beLya2oabyocDEI Ynd0MjBFtZmMESXiVKyznqt16Qv1510sPA2xfehddjfUA92R0bKYpt/W2mULADxa+0h7ygG6/FS QgUykeWJT3gdTagIgj9Zux7lL1eZvZ2nRMOjafGNeEE4TaOHKKDpNHwU5ik9F28ap64elJWwcTY N5LMy9To2rVIOj2Ae6j5n0GpdNst6rZ1ipKMy2ZUJiNHF/l707hqIMkfxSjwQa8lqr+/CvVyW5K kdM35CNRYa0dpN405qvSX0J62J0RWlPH9/fagHsr49f/mLAH2K7ooffZT++VihGeSKEs= X-Received: by 2002:a05:6214:4e04:b0:894:ae65:5ba5 with SMTP id 6a1803df08f44-8953c7aa00cmr23503286d6.2.1770375182514; Fri, 06 Feb 2026 02:53:02 -0800 (PST) X-Received: by 2002:a05:6214:4e04:b0:894:ae65:5ba5 with SMTP id 6a1803df08f44-8953c7aa00cmr23503136d6.2.1770375182153; Fri, 06 Feb 2026 02:53:02 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6598400f3eesm421672a12.19.2026.02.06.02.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 02:53:01 -0800 (PST) Message-ID: <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> Date: Fri, 6 Feb 2026 11:52:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback To: Yongxing Mou , Vinod Koul , Neil Armstrong , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=P5k3RyAu c=1 sm=1 tr=0 ts=6985c80f cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=pDKpTZyYLimyg1k4smoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDA3NCBTYWx0ZWRfX2CjqzrfwpUbV don9Vt0GSEsWjkmetOeHaDQPYYJVwE5UGxJEHE68b2B+F5jvlchBfnPxDk8+vVhKYPL+bIABp7q +IQ/o+2gDzAAt3s9a3vmnoPCorcZ26uQcCCSHtUeNAgejT0QP2IROHGi1uMwS2Hxdso5TvOZ0Gd 9ENti50Mtt3TDAJgMGX22Dp/FyViPQeRpZYkNd+jshZQy9LCH/l+jfFB87n6UtANSh+ExGFJdEt pRQEJw0PNWyBCi9V4CHHtrPlOoTGFs1m6/qLb76LrhxoTIS2XJ4gY+Cumlvh8o+dPEhMa/Vl8q+ gtgDKS13qvIizneCQ8TNOuGQXQtrpR2ju3fam/KSuWwTazO3oVBhwtI8sUgYd7A9/TiniHagt7X 2phmprngR3E3xXRgZyJL0vrSDCDE6+YvglnuPPI3+6QTQZnM+aPdWeF1Y5QBL4qRQpAjLaRc7uL rwPq9KYGVjl/DeBN20A== X-Proofpoint-ORIG-GUID: 6nTd0qI2Zyw1gD9BWpm0lwrnTLpI_0cU X-Proofpoint-GUID: 6nTd0qI2Zyw1gD9BWpm0lwrnTLpI_0cU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_03,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060074 On 2/5/26 10:20 AM, Yongxing Mou wrote: > Introduce the com_ldo_config callback to support per‑PHY LDO > configuration. > > Signed-off-by: Yongxing Mou > --- [...] > +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp) > +{ > + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; > + u32 ldo_config; > + > + if (!edp->is_edp) > + ldo_config = 0x0; > + else if (dp_opts->link_rate <= 2700) > + ldo_config = 0xC1; lowercase hex, please > + else > + ldo_config = 0x81; > + > + writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); > + writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases, I believe Konrad