mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: davidjon@xenontk.org
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	andreas.herrmann3@amd.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] 2.6.33-rc2 - pci: Commit e0cd516 causes OOPS
Date: Fri, 1 Jan 2010 22:55:28 +0100	[thread overview]
Message-ID: <201001012255.28094.rjw@sisk.pl> (raw)
In-Reply-To: <4B3E51FC.9000502@xenontk.org>

On Friday 01 January 2010, David John wrote:
> Hi All,

Hi,

> Commit e0cd516 causes an null pointer dereference when reading from the
> sysfs attributes local_cpu* on Intel machines with no ACPI NUMA
> proximity info, since dev->numa_node gets set to -1 for all PCI devices,
> which then gets passed to cpumask_of_node.
> 
> The patch following this mail fixes the problem for x86. Perhaps a more
> thorough solution would be to fix the PCI layer to set the node
> information for devices to zero rather than -1 (Since if CONFIG_NUMA=y
> we have node 0)? I don't know whether it is safe / correct to do this.

First, it would be nicer if you said what the commit subject was in addition
to providing its hash.

Second, why don't you put the information above into the changelog of your
patch?

Rafael

  parent reply	other threads:[~2010-01-01 21:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-01 19:50 David John
2010-01-01 19:55 ` [PATCH] Check the node argument passed to cpumask_of_node David John
2010-01-01 21:55 ` Rafael J. Wysocki [this message]
2010-01-02  6:15   ` [PATCH v2] " David John
2010-01-04  4:28     ` Rusty Russell
2010-01-04 11:42       ` David John
2010-01-04 14:58         ` [PATCH v3] " David John
2010-01-04 17:18           ` Jesse Barnes
2010-01-04  5:15     ` [PATCH v2] " Jin Dongming
2010-01-01 22:22 ` [Regression] 2.6.33-rc2 - pci: Commit e0cd516 causes OOPS Yinghai Lu
2010-01-02  6:18   ` David John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001012255.28094.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=andreas.herrmann3@amd.com \
    --cc=davidjon@xenontk.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome