From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Hui Zhu <teawater@gmail.com>
Cc: saeed bishara <saeed.bishara@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Nicolas Pitre <nico@fluxnic.net>,
Ralf Baechle <ralf@linux-mips.org>,
David Daney <ddaney@caviumnetworks.com>,
Tomaso Paoletti <tpaoletti@caviumnetworks.com>,
Chris Dearman <chris@mips.com>,
Paul Gortmaker <Paul.Gortmaker@windriver.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Frederic Weisbecker <fweisbec@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Brian Gerst <brgerst@gmail.com>, Tejun Heo <tj@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Coly Li <coly.li@suse.de>
Subject: Re: [PATCH] stack2core: show stack message and convert it to core file when kernel die
Date: Sun, 3 Jan 2010 16:44:14 +0000 [thread overview]
Message-ID: <20100103164414.GB21156@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <daef60381001030830u176c0cfavbb31358a2b42ed60@mail.gmail.com>
On Mon, Jan 04, 2010 at 12:30:20AM +0800, Hui Zhu wrote:
> This S2C: message just for program s2c.
> s2c can convert it to a core file. Then gdb can do a clear analyse
> with this file.
> Then you can get more message than current we can get.
I understand that. What I'm saying is that all the additional noise
you're causing the kernel to create is just a pure duplication of
what we already dump.
Oops dumps are already noisy enough - especially if they cause a panic
at the end (where you end up with two backtraces.) We do not need even
more noise caused by needless duplication.
You can get everything you need already from the kernel. On ARM, we
already dump out all the registers and the _full_ stack. There is no
need for you to implement your own register dumping code and full stack
dump on top of that again.
So, I'm not going to accept your patch for the ARM kernel. Please use
what's already provided - it's more than adequate. By doing so, you
don't penalise those of us who want to read the raw oopses.
Talking about noisy oopses, I'm getting one with 2.6.33-rc2 on 'poweroff'
shutdown. No idea what it is because most of it's scrolled off the top of
the screen and I can't scroll back. Not bothered about it at the moment.
What it does illustrate though is why making things too noisy when problems
occur makes it _more_ difficult to find out what went wrong.
next prev parent reply other threads:[~2010-01-03 16:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-03 15:05 Hui Zhu
2010-01-03 16:03 ` Russell King - ARM Linux
2010-01-03 16:30 ` Hui Zhu
2010-01-03 16:44 ` Russell King - ARM Linux [this message]
2010-01-03 16:55 ` Hui Zhu
2010-01-03 17:10 ` Russell King - ARM Linux
2010-01-03 17:18 ` Hui Zhu
2010-01-03 17:37 ` Hui Zhu
2010-01-03 17:26 ` Arjan van de Ven
2010-01-03 17:39 ` Hui Zhu
2010-01-03 17:47 ` Russell King - ARM Linux
2010-01-03 18:32 ` Marek Vasut
2010-01-03 22:49 ` Tejun Heo
2010-01-03 23:01 ` Arjan van de Ven
2010-01-03 23:07 ` Tejun Heo
2010-01-03 23:14 ` Arjan van de Ven
2010-01-03 23:24 ` Tejun Heo
2010-01-04 16:22 ` Hui Zhu
2010-01-04 23:03 ` Tejun Heo
2010-01-05 9:04 ` Hui Zhu
2010-01-05 9:20 ` Tejun Heo
2010-01-06 7:07 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100103164414.GB21156@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Paul.Gortmaker@windriver.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brgerst@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chris@mips.com \
--cc=coly.li@suse.de \
--cc=ddaney@caviumnetworks.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=nico@fluxnic.net \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=saeed.bishara@gmail.com \
--cc=teawater@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tpaoletti@caviumnetworks.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®