From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: Clean up build for CONFIG_PCI_QUIRKS unset
Date: Mon, 4 Jan 2010 15:47:48 -0800 [thread overview]
Message-ID: <20100104154748.2b282be6@jbarnes-piketon> (raw)
In-Reply-To: <201001022257.24701.rjw@sisk.pl>
On Sat, 2 Jan 2010 22:57:24 +0100
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Currently, drivers/pci/quirks.c is built unconditionally, but if
> CONFIG_PCI_QUIRKS is unset, the only things actually built in this
> file are definitions of global variables and empty functions (due to
> the #ifdef CONFIG_PCI_QUIRKS embracing all of the code inside the
> file). This is not particularly nice and if someone overlooks
> the #ifdef CONFIG_PCI_QUIRKS, build errors are introduced.
>
> To clean that up, move the definitions of the global variables in
> quirks.c that are always built to pci.c, move the definitions of
> the empty functions (compiled when CONFIG_PCI_QUIRKS is unset) to
> headers (additionally make these functions static inline) and modify
> drivers/pci/Makefile so that quirks.c is only built if
> CONFIG_PCI_QUIRKS is set.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>
> I thought it might be useful to do something like this.
>
> Please let me know what you think.
Applied to my linux-next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-01-04 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 21:57 Rafael J. Wysocki
2010-01-04 16:34 ` Jesse Barnes
2010-01-04 19:55 ` Jesse Barnes
2010-01-04 23:47 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104154748.2b282be6@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®