From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753909Ab0ADWdJ (ORCPT ); Mon, 4 Jan 2010 17:33:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753157Ab0ADWdI (ORCPT ); Mon, 4 Jan 2010 17:33:08 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:53850 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753668Ab0ADWdE (ORCPT ); Mon, 4 Jan 2010 17:33:04 -0500 Date: Mon, 4 Jan 2010 22:36:20 +0000 From: Alan Cox To: Stefani Seibold Cc: James Bottomley , Jiri Kosina , Linus Torvalds , Andrew Morton , linux-kernel , linux-scsi Subject: Re: [PATCH] libsrp: fix compile failure Message-ID: <20100104223620.4659a241@lxorguk.ukuu.org.uk> In-Reply-To: <1262633054.4814.21.camel@wall-e> References: <1262200866.2749.226.camel@mulgrave.site> <1262625721.2724.158.camel@mulgrave.site> <20100104173530.48690e39@lxorguk.ukuu.org.uk> <1262633054.4814.21.camel@wall-e> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Jan 2010 20:24:14 +0100 Stefani Seibold wrote: > Am Montag, den 04.01.2010, 17:35 +0000 schrieb Alan Cox: > > > least once before it goes to Linus. There were originally technical > > > reasons why -mm wasn't in ... I just thought they'd been fixed by now. > > > > No - mm also caused problems with the kfifo merge of a core API change > > that didn't go via -next. > > > > Alan > > I tried my best to port everything to the new kfifo API. But it was not > possible to check it against every architecture. x86 and x86_64 was > compile clean. I think the missing #include was not a big thing. Not your fault - -next is there so stuff is visible for merging and to avoid collisions. Andrew not going via -next broke various pending patches. Conversion is easy enough, it just wasn't visible at the right time.