From: Andrew Morton <akpm@linux-foundation.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Debora Velarde <debora@linux.vnet.ibm.com>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
Marcel Selhorst <m.selhorst@sirrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm_infineon: Fix suspend/resume handler for pnp_driver
Date: Tue, 5 Jan 2010 15:59:00 -0800 [thread overview]
Message-ID: <20100105155900.7cf92358.akpm@linux-foundation.org> (raw)
In-Reply-To: <87d41xu18p.fsf@devron.myhome.or.jp>
On Wed, 30 Dec 2009 02:41:10 +0900
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> Hi,
>
> With recent quick review, I found the bug of tpm_infineon. (I don't have
> this device, and compile test only)
>
hm. What bug? Is there a bugzilla reference, or do you have a
description of that bug? Perhaps the device is not functional after
suspend/resume?
This matters because people who are experiencing problems with this
device will want to know whether this patch is likely to fix them
(although that'll be pretty obvious in this case).
It also matters because people (ie: me) will want to know whether the
bug is sufficiently serious to warrant backporting the fix into earlier
-stable kernels.
Is the patch actually needed in earlier kernels? It applies cleanly.
When did this pnp_driver->suspend/resume requirement come about?
> PNP driver must use pnp_driver->suspend/resume anymore.
I assume this text should have read "PNP driver must use
pnp_driver->suspend/resume.".
next prev parent reply other threads:[~2010-01-05 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 17:41 OGAWA Hirofumi
2010-01-05 23:59 ` Andrew Morton [this message]
2010-01-09 23:39 ` OGAWA Hirofumi
2010-01-11 12:19 ` Marcel Selhorst
2010-02-01 11:14 ` Marcel Selhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105155900.7cf92358.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=debora@linux.vnet.ibm.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=m.selhorst@sirrix.com \
--cc=srajiv@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome