From: Samuel Ortiz <sameo@linux.intel.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: kernel list <linux-kernel@vger.kernel.org>, ian@mnementh.co.uk
Subject: Re: [PATCH] tc6393xb.c: use resource_size()
Date: Tue, 5 Jan 2010 20:03:25 +0100 [thread overview]
Message-ID: <20100105190325.GI4274@sortiz.org> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901FB110D@mi8nycmail19.Mi8.com>
Hi Hartley,
On Fri, Dec 11, 2009 at 07:11:13PM -0500, H Hartley Sweeten wrote:
> Use resource_size() for ioremap.
Patch applied too, many thanks.
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Molton <ian@mnementh.co.uk>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
>
> ---
>
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index 1429a73..50b1610 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -610,7 +610,7 @@ static int __devinit tc6393xb_probe(struct platform_device *dev)
> if (ret)
> goto err_request_scr;
>
> - tc6393xb->scr = ioremap(rscr->start, rscr->end - rscr->start + 1);
> + tc6393xb->scr = ioremap(rscr->start, resource_size(rscr));
> if (!tc6393xb->scr) {
> ret = -ENOMEM;
> goto err_ioremap;
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-01-05 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 0:11 H Hartley Sweeten
2010-01-05 19:03 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105190325.GI4274@sortiz.org \
--to=sameo@linux.intel.com \
--cc=hartleys@visionengravers.com \
--cc=ian@mnementh.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome