From: Simon Horman <horms@verge.net.au>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>, Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org
Subject: Re: [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf
Date: Wed, 6 Jan 2010 13:34:16 +1100 [thread overview]
Message-ID: <20100106023416.GB18557@verge.net.au> (raw)
In-Reply-To: <da25f48ee7959e83a18e3705c223c8619e508bf4.1262726222.git.joe@perches.com>
On Tue, Jan 05, 2010 at 05:20:18PM -0800, Joe Perches wrote:
> Use the same format string as net/ipv4/netfilter/nf_nat_ftp.c
> to encode an ipv4 address and port.
>
> Both uses should be a single common function.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Simon Horman <horms@verge.net.au>
> ---
> net/netfilter/ipvs/ip_vs_ftp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> index 33e2c79..73f38ea 100644
> --- a/net/netfilter/ipvs/ip_vs_ftp.c
> +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> @@ -208,7 +208,7 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp,
> */
> from.ip = n_cp->vaddr.ip;
> port = n_cp->vport;
> - sprintf(buf, "%d,%d,%d,%d,%d,%d", NIPQUAD(from.ip),
> + sprintf(buf, "%u,%u,%u,%u,%u,%u", NIPQUAD(from.ip),
> (ntohs(port)>>8)&255, ntohs(port)&255);
> buf_len = strlen(buf);
>
> --
> 1.6.6.rc0.57.gad7a
>
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-01-06 2:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 1:20 [PATCH 0/8] Remove most uses of NIPQUAD and NIPQUAD_FMT Joe Perches
2010-01-06 1:20 ` [PATCH 1/8] drivers/scsi: Remove uses of NIPQUAD, use %pI4 Joe Perches
2010-01-06 1:20 ` [PATCH 2/8] drivers/staging/pohmelfs/inode.c: " Joe Perches
2010-01-06 1:20 ` [PATCH 3/8] net/rds: " Joe Perches
2010-01-06 1:20 ` [PATCH 4/8] net/sunrpc: " Joe Perches
2010-01-06 1:20 ` [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4 Joe Perches
2010-01-06 19:23 ` [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4 Joe Perches
2010-01-11 10:51 ` Patrick McHardy
2010-01-11 11:09 ` [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists Joe Perches
2010-01-11 11:14 ` Patrick McHardy
2010-01-11 11:27 ` [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes Joe Perches
2010-01-11 11:31 ` Jan Engelhardt
2010-01-11 11:43 ` Joe Perches
2010-01-12 18:46 ` [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER Joe Perches
2010-01-13 15:13 ` Stefan Richter
2010-01-13 16:15 ` Joe Perches
2010-01-13 17:10 ` Stefan Richter
2010-01-15 20:03 ` Pavel Machek
2010-01-06 1:20 ` [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Joe Perches
2010-01-06 2:34 ` Simon Horman [this message]
2010-01-11 10:54 ` Patrick McHardy
2010-01-06 1:20 ` [PATCH 7/8] fs/ocfs2/cluster/tcp.c: Remove use of NIPQUAD, use %pI4 Joe Perches
2010-01-07 1:51 ` Joel Becker
2010-01-06 1:20 ` [PATCH 8/8] drivers/firmware/iscsi_ibft.c: Remove NIPQUAD_FMT, " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106023416.GB18557@verge.net.au \
--to=horms@verge.net.au \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®