From: Simon Horman <horms@verge.net.au>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
macro@linux-mips.org, hartleys@visionengravers.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf.c: Add %pMF to format FDDI bit reversed MAC addresses
Date: Fri, 8 Jan 2010 13:48:02 +1100 [thread overview]
Message-ID: <20100108024802.GB2465@verge.net.au> (raw)
In-Reply-To: <1262915508.10429.99.camel@Joe-Laptop.home>
On Thu, Jan 07, 2010 at 05:51:48PM -0800, Joe Perches wrote:
> On Fri, 2010-01-08 at 11:08 +1100, Simon Horman wrote:
> > In the vein of this, would it be worth adding some modifier to %i4 to
> > print addresses for ftp helpers? That is, %u,%u,%u,%u. I think
> > there are currently two users of that format string after Joe's latest
> > round of updates.
>
> I think not. I think the comma separated uses
> are unusual enough to not support in lib/vsprintf.
Sounds reasonable.
> I did submit a patch to support format strings
> for le32 and u32 ipv4 addresses.
>
> > The users are net/netfilter/ipvs/ip_vs_ftp.c and
> > net/ipv4/netfilter/nf_nat_ftp.c. Prior to Joe's latest
> > changes ip_vs_ftp.c used %d,%d,%d,%d.
>
> I submitted a couple of patches that should help.
>
> o eventually remove NIPQUAD and NIPQUAD_FMT
> o consolidate the 2 netfilter "%u,%u,%u,%u" uses
> to a single function
next prev parent reply other threads:[~2010-01-08 2:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BD79186B4FD85F4B8E60E381CAEE19090208954A@mi8nycmail19.Mi8.com>
2010-01-07 18:23 ` Joe Perches
2010-01-07 20:42 ` Maciej W. Rozycki
2010-01-07 21:13 ` Michał Mirosław
2010-01-07 22:09 ` David Miller
2010-01-08 0:08 ` Simon Horman
2010-01-08 1:51 ` Joe Perches
2010-01-08 2:48 ` Simon Horman [this message]
2010-01-07 21:18 ` Michał Mirosław
2010-01-07 21:36 ` Joe Perches
2010-01-07 21:37 ` [PATCH V2] " Joe Perches
2010-01-07 22:11 ` David Miller
2010-01-07 21:43 ` [PATCH V3] " Joe Perches
2010-01-08 0:58 ` David Miller
2010-01-19 10:57 ` [PATCH] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108024802.GB2465@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®