mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: "Peter Hüwe" <PeterHuewe@gmx.de>
Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
	devel@driverdev.osuosl.org,
	Randy Dunlap <randy.dunlap@oracle.com>,
	linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH 2/3 v2] staging/rtl8192u: Add select WEXT_PRIV to Kconfig to prevent build failure
Date: Fri, 8 Jan 2010 21:18:25 +1100	[thread overview]
Message-ID: <20100108101822.GA27997@verge.net.au> (raw)
In-Reply-To: <201001080914.39084.PeterHuewe@gmx.de>

On Fri, Jan 08, 2010 at 09:14:38AM +0100, Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
> Date: Fri, 8 Jan 2010 09:10:13 +0100
> 
> Without WEXT_PRIV set the driver fails to build due to unknown fields in
> the iw_handler_def struct.
> Those fields are enclosed in WEXT_PRIV conditionals in the prototype
> of iw_handler_def in include/net/iw_handler.h
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

Acked-by: Simon Horman <horms@verge.net.au>

depends on WIRELESS_EXT should be select WIRELESS_EXT.
Do you want to handle that?

> ---
> This time without whitespace error  - sorry about that.
> 
>  drivers/staging/rtl8192u/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig
> index 9913ab8..d7bc35c 100644
> --- a/drivers/staging/rtl8192u/Kconfig
> +++ b/drivers/staging/rtl8192u/Kconfig
> @@ -2,5 +2,6 @@ config RTL8192U
>  	tristate "RealTek RTL8192U Wireless LAN NIC driver"
>  	depends on PCI && WLAN && USB
>  	depends on WIRELESS_EXT
> +	select WEXT_PRIV
>  	default N
>  	---help---
> -- 
> 1.6.4.4

  reply	other threads:[~2010-01-08 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 20:33 [PATCH 1/3] staging/otus: " Peter Huewe
2010-01-07 20:35 ` [PATCH 2/3] staging/rtl8192u: " Peter Huewe
2010-01-07 20:36   ` [PATCH 3/3] staging/wlan-ng: " Peter Huewe
2010-01-08  0:35     ` Simon Horman
2010-01-08  8:14   ` [PATCH 2/3 v2] staging/rtl8192u: " Peter Hüwe
2010-01-08 10:18     ` Simon Horman [this message]
2010-01-08 10:44       ` [PATCH 2/3 v3] " Peter Hüwe
2010-01-08  0:37 ` [PATCH 1/3] staging/otus: " Simon Horman
2010-01-08  8:13 ` [PATCH 1/3 v2] " Peter Hüwe
2010-01-08 10:18   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100108101822.GA27997@verge.net.au \
    --to=horms@verge.net.au \
    --cc=PeterHuewe@gmx.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome