From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Eric Anholt <eric@anholt.net>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS
Date: Fri, 8 Jan 2010 17:13:11 -0800 [thread overview]
Message-ID: <20100108171311.128c43d0@jbarnes-piketon> (raw)
In-Reply-To: <alpine.LFD.2.00.1001081648490.7821@localhost.localdomain>
On Fri, 8 Jan 2010 16:50:57 -0800 (PST)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Sat, 9 Jan 2010, Rafael J. Wysocki wrote:
> >
> > Which is functionally equivalent to my patch, because
> > i915_suspend/resume() won't be called by drm_class_suspend/resume()
> > in the KMS case anyway.
>
> Ahh, right you are - that class suspend function does a check for
> DRIVER_MODESET, and only does the suspend/resume if it's not a
> MODESET driver.
>
> Ok, so I withdraw my objections to your original patch - it's
> confusing, but that's just because DRM is such a horrible mess with
> subtle things.
Yeah the non-KMS paths just suck.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Though hopefully you can get the PCI driver registration working w/o
too much trouble; that would be even better.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-01-09 1:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 23:45 Rafael J. Wysocki
2010-01-09 0:01 ` Linus Torvalds
2010-01-09 0:06 ` Jesse Barnes
2010-01-09 0:21 ` Jesse Barnes
2010-01-09 0:43 ` Rafael J. Wysocki
2010-01-09 0:21 ` Rafael J. Wysocki
2010-01-09 0:32 ` Jesse Barnes
2010-01-09 0:46 ` Rafael J. Wysocki
2010-01-09 0:50 ` Linus Torvalds
2010-01-09 1:13 ` Jesse Barnes [this message]
2010-01-09 13:35 ` [PATCH] i915: Always register as a PCI driver (was: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS) Rafael J. Wysocki
2010-01-09 21:41 ` Dave Airlie
2010-01-09 22:07 ` Rafael J. Wysocki
2010-01-09 2:15 ` [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS Dave Airlie
2010-01-09 2:50 ` Jesse Barnes
2010-01-09 12:01 ` Jerome Glisse
2010-01-09 18:17 ` Linus Torvalds
2010-01-09 21:32 ` Dave Airlie
2010-01-11 16:38 ` Jesse Barnes
2010-01-11 20:12 ` Dave Airlie
2010-01-11 20:22 ` Jesse Barnes
2010-01-11 21:04 ` Rafael J. Wysocki
2010-01-11 21:43 ` Julien Cristau
2010-01-11 22:22 ` Rafael J. Wysocki
2010-01-11 23:05 ` Dave Airlie
2010-01-11 23:16 ` Rafael J. Wysocki
2010-01-12 22:33 ` Eric Anholt
2010-01-12 22:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108171311.128c43d0@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®