From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341Ab0AHWwe (ORCPT ); Fri, 8 Jan 2010 17:52:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754233Ab0AHWwd (ORCPT ); Fri, 8 Jan 2010 17:52:33 -0500 Received: from rhlx01.hs-esslingen.de ([129.143.116.10]:45377 "EHLO rhlx01.hs-esslingen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754259Ab0AHWwc (ORCPT ); Fri, 8 Jan 2010 17:52:32 -0500 Date: Fri, 8 Jan 2010 23:52:31 +0100 From: Andreas Mohr To: "H. Peter Anvin" Cc: Christoph Hellwig , Al Viro , Matthew Wilcox , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux@arm.linux.org.uk, dhowells@redhat.com, ysato@users.sourceforge.jp, tony.luck@intel.com Subject: Re: [PATCH 1/3] generic sys_old_select Message-ID: <20100108225231.GA11332@rhlx01.hs-esslingen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Priority: none User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > There is, however, a reason *not* to do it which should be carefully > considered: by co-locating the compatibility version with the modern > version, it gets access to static functions that are part of the > implementation of the modern version. If we move the compatibility > versions out, it may entail having to export those statics. > > -hpa Hmm, do I hear a reason to simply fully #include the (newly separated) old-style .c file from within the new-style .c file? Not necessarily a wonderful approach, but perhaps it beats doing a "correct full separation" and thus having a couple new-born (and unhappy ;) exports any day? Andreas Mohr