From: Jean Delvare <khali@linux-fr.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Tomaz Mertelj <tomaz.mertelj@guest.arnes.si>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [patch] hwmon/amc6821: double unlock bug
Date: Thu, 14 Jan 2010 12:49:48 +0100 [thread overview]
Message-ID: <20100114124948.79c9d4d3@hyperion.delvare> (raw)
In-Reply-To: <20100114103020.GA4939@bicker>
On Thu, 14 Jan 2010 13:30:20 +0300, Dan Carpenter wrote:
> The mutex gets unlocked after we goto EXIT.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> --- orig/drivers/hwmon/amc6821.c 2010-01-14 13:22:23.000000000 +0300
> +++ devel/drivers/hwmon/amc6821.c 2010-01-14 13:22:30.000000000 +0300
> @@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
> data->fan1_div = 4;
> break;
> default:
> - mutex_unlock(&data->update_lock);
> count = -EINVAL;
> goto EXIT;
> }
Good catch. Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2010-01-14 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 10:30 Dan Carpenter
2010-01-14 11:49 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114124948.79c9d4d3@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=tomaz.mertelj@guest.arnes.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome