From: Jim Keniston <jkenisto@us.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
utrace-devel <utrace-devel@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
Maneesh Soni <maneesh@in.ibm.com>, Mark Wielaard <mjw@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH 1/7] User Space Breakpoint Assistance Layer (UBP)
Date: Sat, 16 Jan 2010 18:48:33 -0500 [thread overview]
Message-ID: <20100116184833.2s0zihwbggkgccsk@imap.linux.ibm.com> (raw)
Quoting Peter Zijlstra <peterz@infradead.org>:
> On Fri, 2010-01-15 at 16:58 -0800, Jim Keniston wrote:
>> But here are some things to keep in mind about the
>> various approaches:
>>
>> 1. Single-stepping inline is easiest: you need to know very little about
>> the instruction set you're probing. But it's inadequate for
>> multithreaded apps.
>> 2. Single-stepping out of line solves the multithreading issue (as do #3
>> and #4), but requires more knowledge of the instruction set. (In
>> particular, calls, jumps, and returns need special care; as do
>> rip-relative instructions in x86_64.) I count 9 architectures that
>> support kprobes. I think most of these do SSOL.
>> 3. "Boosted" probes (where an appended jump instruction removes the need
>> for the single-step trap on many instructions) require even more
>> knowledge of the instruction set, and like SSOL, require XOL slots.
>> Right now, as far as I know, x86 is the only architecture with boosted
>> kprobes.
>> 4. Emulation removes the need for the XOL area, but requires pretty much
>> total knowledge of the instruction set. It's also a performance win for
>> architectures that can't do #3. I see kvm implemented on 4
>> architectures (ia64, powerpc, s390, x86). Coincidentally, those are the
>> architectures to which uprobes (old uprobes, with ubp and xol bundled
>> in) has already been ported (though Intel hasn't been maintaining their
>> ia64 port).
>
> Right, so I was thinking a combination of 4 and execute from kernel
> space would be feasible. I would think most regular instructions are
> runnable from kernel space given that we provide the proper pt_regs
> environment.
>
> Although I just realize we need to fully emulate the address computation
> step for all memory writes, otherwise a wild userspace pointer might end
> up writing in your kernel image.
Correct.
>
> Also, don't we already need full knowledge of the instruction set in
> order to decode the instruction stream and find instruction boundaries.
Not really. For #3 (boosting), you need to know everything for #2,
plus be able to compute the length of each instruction -- which we can
now do for x86. To emulate an instruction (#4), you need to replicate
what it does, side-effects and all. The x86 instruction set seems to
be adding new floating-point instructions all the time, and I bet even
Masami doesn't know what they all do, but so far, they all seem to
adhere to the instruction-length rules encoded in Masami's instruction
decoder.
As you may have noted before, I think FP would be a special problem
for your approach. I'm not sure how folks would react to the idea of
executing FP instructions in kernel space. But emulating them is also
tough. There's an IEEE FP emulation package somewhere in one of the
Linux arch directories, but I'm not sure how precise it is, and
dropping even 1 bit of precision is unacceptable for many
applications, since such errors tend to grow in complex computations
employing many FP instructions.
Jim
next reply other threads:[~2010-01-16 23:48 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 23:48 Jim Keniston [this message]
2010-01-18 7:23 ` Peter Zijlstra
2010-01-18 15:58 ` Masami Hiramatsu
2010-01-18 19:21 ` Jim Keniston
2010-01-18 21:20 ` Masami Hiramatsu
-- strict thread matches above, loose matches on Subject: below --
2010-01-11 12:25 [RFC] [PATCH 0/7] UBP, XOL and Uprobes Srikar Dronamraju
2010-01-11 12:25 ` [RFC] [PATCH 1/7] User Space Breakpoint Assistance Layer (UBP) Srikar Dronamraju
2010-01-14 11:08 ` Peter Zijlstra
2010-01-14 19:46 ` Jim Keniston
2010-01-15 9:02 ` Peter Zijlstra
2010-01-15 21:07 ` Jim Keniston
2010-01-15 21:49 ` Peter Zijlstra
2010-01-16 0:58 ` Jim Keniston
2010-01-16 10:33 ` Peter Zijlstra
2010-01-17 0:12 ` Bryan Donlan
2010-01-18 7:37 ` Peter Zijlstra
2010-01-17 14:37 ` Avi Kivity
2010-01-15 9:03 ` Peter Zijlstra
2010-01-15 9:38 ` Ananth N Mavinakayanahalli
2010-01-15 9:50 ` Peter Zijlstra
2010-01-15 10:10 ` Ananth N Mavinakayanahalli
2010-01-15 10:13 ` Peter Zijlstra
2010-01-15 10:22 ` Ananth N Mavinakayanahalli
2010-01-15 10:56 ` Peter Zijlstra
2010-01-15 11:02 ` Peter Zijlstra
2010-01-15 21:19 ` Jim Keniston
2010-01-17 14:39 ` Avi Kivity
2010-01-17 14:52 ` Peter Zijlstra
2010-01-17 14:56 ` Avi Kivity
2010-01-17 15:01 ` Peter Zijlstra
2010-01-20 12:55 ` Pavel Machek
2010-01-17 14:59 ` Avi Kivity
2010-01-17 15:03 ` Peter Zijlstra
2010-01-17 19:33 ` Avi Kivity
2010-01-18 7:45 ` Peter Zijlstra
2010-01-18 11:01 ` Avi Kivity
2010-01-18 11:44 ` Peter Zijlstra
2010-01-18 12:01 ` Avi Kivity
2010-01-18 12:06 ` Peter Zijlstra
2010-01-18 12:09 ` Avi Kivity
2010-01-18 12:13 ` Pekka Enberg
2010-01-18 12:17 ` Avi Kivity
2010-01-18 12:24 ` Peter Zijlstra
2010-01-18 12:24 ` Pekka Enberg
2010-01-18 12:44 ` Srikar Dronamraju
2010-01-18 12:51 ` Pekka Enberg
2010-01-18 12:53 ` Avi Kivity
2010-01-18 12:57 ` Pekka Enberg
2010-01-18 13:06 ` Avi Kivity
2010-01-18 22:15 ` Jim Keniston
2010-01-19 8:07 ` Avi Kivity
2010-01-19 17:47 ` Jim Keniston
2010-01-19 18:06 ` Frederic Weisbecker
2010-01-20 6:36 ` Srikar Dronamraju
2010-01-20 10:51 ` Frederic Weisbecker
2010-01-20 19:31 ` Masami Hiramatsu
2010-01-20 9:43 ` Avi Kivity
2010-01-20 9:57 ` Peter Zijlstra
2010-01-20 12:22 ` Avi Kivity
2010-01-27 8:24 ` Ingo Molnar
2010-01-27 8:35 ` Avi Kivity
2010-01-27 9:08 ` Ingo Molnar
2010-01-27 9:25 ` Avi Kivity
2010-01-27 10:23 ` Ingo Molnar
2010-02-07 13:47 ` Avi Kivity
2010-01-20 10:45 ` Srikar Dronamraju
2010-01-20 12:23 ` Avi Kivity
2010-01-20 18:31 ` Andi Kleen
2010-01-20 19:34 ` Jim Keniston
2010-01-20 19:58 ` Andi Kleen
2010-01-20 20:28 ` Jim Keniston
2010-01-18 13:05 ` Peter Zijlstra
2010-01-18 13:34 ` Mark Wielaard
2010-01-18 19:49 ` Jim Keniston
2010-01-18 15:43 ` Ananth N Mavinakayanahalli
2010-01-18 16:52 ` Avi Kivity
2010-01-18 17:10 ` Ananth N Mavinakayanahalli
2010-01-18 12:14 ` Peter Zijlstra
2010-01-18 12:37 ` Avi Kivity
2010-01-18 13:15 ` Peter Zijlstra
2010-01-18 13:33 ` Avi Kivity
2010-01-18 13:34 ` K.Prasad
2010-01-20 15:57 ` Mel Gorman
2010-01-20 18:32 ` Andi Kleen
2010-01-18 11:45 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100116184833.2s0zihwbggkgccsk@imap.linux.ibm.com \
--to=jkenisto@us.ibm.com \
--cc=acme@infradead.org \
--cc=ananth@in.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mjw@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=utrace-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®