From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Alex Chiang <achiang@hp.com>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 10/11] pciehp: add support for bridge resource reallocation
Date: Sun, 17 Jan 2010 09:34:18 -0800 [thread overview]
Message-ID: <20100117093418.6d545b43@jbarnes-piketon> (raw)
In-Reply-To: <1263683671.29907.47.camel@dc7800.home>
On Sat, 16 Jan 2010 16:14:31 -0700
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Sat, 2010-01-16 at 01:34 -0800, Yinghai Lu wrote:
> > On 01/15/2010 08:59 PM, Alex Chiang wrote:
> > > * Yinghai Lu <yinghai@kernel.org>:
> > >> From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> > >>
> > >> With this patch, pciehp driver try to clear PCI bridge resources
> > >> to parent bridge (root port or switch downstream port) of the
> > >> slot
> > >>
> > >> so we can shrink pci bridge resource for those port
> > >>
> > >> This feature is enabled when 'pciehp_realloc' option is
> > >> specified.
> > >>
> > >> -v2: make it could be appiled after Yinghai patchset that touch
> > >> pci bridge resource also remove poweron check, because
> > >> pci_bridge_release_res will check child at first
> > >
> > > Same comment as my earlier patch. Why not just make this the
> > > default behavior, instead of introducing yet another command line
> > > parameter for users to guess at?
> >
> > it will break Eric's setup/
>
> I think this is a clue that we don't understand the problem well
> enough yet.
>
> I'm opposed to adding kernel parameters for this sort of thing. It is
> unreasonable to expect users to figure out whether they need to use
> this parameter or not.
>
> Special-case switches like this make it much harder to maintain the
> code in the future.
Agreed. Yinghai, what's wrong in the new reassignment code that
causes Eric's setup to break? Can we just fix that instead and enable
reallocation by default?
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-01-17 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 2:41 [PATCH 00/11] pci: update pci bridge resources Yinghai Lu
2010-01-16 2:41 ` [PATCH 01/11] pci: add pci_bridge_release_unused_res and pci_bus_release_unused_bridge_res Yinghai Lu
2010-01-16 3:57 ` Alex Chiang
2010-01-16 10:10 ` Yinghai Lu
2010-01-16 2:41 ` [PATCH 02/11] pci: add failed_list to record failed one for pci_bus_assign_resources Yinghai Lu
2010-01-16 4:05 ` Alex Chiang
2010-01-16 2:41 ` [PATCH 03/11] pci: reject mmio range start from 0 on pci_bridge read Yinghai Lu
2010-01-16 4:20 ` Alex Chiang
2010-01-16 2:41 ` [PATCH 04/11] pci: don't shrink bridge resources Yinghai Lu
2010-01-16 2:41 ` [PATCH 05/11] pci: update bridge res to get more big range in pci assign unssign Yinghai Lu
2010-01-16 4:38 ` Alex Chiang
2010-01-16 2:41 ` [PATCH 06/11] pci: introduce pci_assign_unassigned_bridge_resources Yinghai Lu
2010-01-16 4:47 ` Alex Chiang
2010-01-16 2:41 ` [PATCH 07/11] pci: pciehp clean flow in pciehp_configure_device Yinghai Lu
2010-01-16 2:41 ` [PATCH 08/11] pci: pciehp second try to get big range for pcie devices Yinghai Lu
2010-01-16 4:52 ` Alex Chiang
2010-01-16 2:41 ` [PATCH 09/11] pci: pci_bridge_release_res Yinghai Lu
2010-01-16 4:57 ` Alex Chiang
2010-01-16 2:42 ` [PATCH 10/11] pciehp: add support for bridge resource reallocation Yinghai Lu
2010-01-16 4:59 ` Alex Chiang
2010-01-16 5:22 ` Yinghai Lu
2010-01-16 9:34 ` Yinghai Lu
2010-01-16 23:14 ` Bjorn Helgaas
2010-01-17 17:34 ` Jesse Barnes [this message]
2010-01-17 22:35 ` Yinghai Lu
2010-01-16 2:42 ` [PATCH 11/11] pci: set PCI_PREF_RANGE_TYPE_64 in pci_bridge_check_ranges Yinghai Lu
2010-01-16 11:07 [PATCH 00/11] pci: update pci bridge resources Yinghai Lu
2010-01-16 11:07 ` [PATCH 10/11] pciehp: add support for bridge resource reallocation Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117093418.6d545b43@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=achiang@hp.com \
--cc=bjorn.helgaas@hp.com \
--cc=ink@jurassic.park.msu.ru \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®