From: Andres Salomon <dilinger@collabora.co.uk>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: trivial@kernel.org, marcelo@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: fix grammo in tsc comment about Geode TSC reliability
Date: Mon, 18 Jan 2010 10:16:30 -0500 [thread overview]
Message-ID: <20100118101630.7ba94ab8@mycelium.queued.net> (raw)
In-Reply-To: <1263764685-9871-1-git-send-email-cascardo@holoscopio.com>
Acked-by: Andres Salomon <dilinger@collabora.co.uk>
That code should probably exist for generic kernels (distro kernels
that aren't compiled specifically for GEODE_LX). Currently it's
#ifdef'd..
On Sun, 17 Jan 2010
19:44:44 -0200 Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
wrote:
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> ---
> arch/x86/kernel/tsc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 597683a..23066ec 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -806,7 +806,7 @@ static void __init check_system_tsc_reliable(void)
> unsigned long res_low, res_high;
>
> rdmsr_safe(MSR_GEODE_BUSCONT_CONF0, &res_low, &res_high);
> - /* Geode_LX - the OLPC CPU has a possibly a very reliable
> TSC */
> + /* Geode_LX - the OLPC CPU has a very reliable TSC */
> if (res_low & RTSC_SUSP)
> tsc_clocksource_reliable = 1;
> #endif
next prev parent reply other threads:[~2010-01-18 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 21:44 Thadeu Lima de Souza Cascardo
2010-01-18 15:16 ` Andres Salomon [this message]
2010-01-19 14:22 ` [tip:x86/cleanups] x86, trivial: Fix " tip-bot for Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118101630.7ba94ab8@mycelium.queued.net \
--to=dilinger@collabora.co.uk \
--cc=cascardo@holoscopio.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®