mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: torvalds@linux-foundation.org, hpa@zytor.com, mingo@elte.hu,
	tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Chris McDermott <lcm@linux.vnet.ibm.com>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Yinghai Lu <yinghai@kernel.org>,
	stable@kernel.org
Subject: [patch 1/2] x86, apic: use physical mode for IBM summit platforms
Date: Mon, 18 Jan 2010 12:10:48 -0800	[thread overview]
Message-ID: <20100118201256.604267529@sbs-t61.sc.intel.com> (raw)

[-- Attachment #1: ibm_summit_oem_check_for_x64.patch --]
[-- Type: text/plain, Size: 1327 bytes --]

Chris McDermott from IBM confirmed that hurricane chipset in IBM summit
platforms doesn't support logical flat mode. Irrespective of the other things
like apic_id's, total number of logical cpu's, Linux kernel should default
to physical mode for this system. 32bit kernel does so using the OEM checks
for the IBM summit platform. Add a similar OEM platform check for the 64bit
kernel too. Otherwise the linux kernel boot can hang on this platform under
certain bios/platform settings.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Tested-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Chris McDermott <lcm@linux.vnet.ibm.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: stable@kernel.org
---
 arch/x86/kernel/apic/apic_flat_64.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: tip/arch/x86/kernel/apic/apic_flat_64.c
===================================================================
--- tip.orig/arch/x86/kernel/apic/apic_flat_64.c
+++ tip/arch/x86/kernel/apic/apic_flat_64.c
@@ -240,6 +240,11 @@ static int physflat_acpi_madt_oem_check(
 		printk(KERN_DEBUG "system APIC only can use physical flat");
 		return 1;
 	}
+
+	if (!strncmp(oem_id, "IBM", 3) && !strncmp(oem_table_id, "EXA", 3)) {
+		printk(KERN_DEBUG "IBM Summit detected, will use apic physical");
+		return 1;
+	}
 #endif
 
 	return 0;



             reply	other threads:[~2010-01-18 20:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 20:10 Suresh Siddha [this message]
2010-01-18 20:10 ` [patch 2/2] x86, apic: use logical flat for systems with <= 8 logical cpus Suresh Siddha
2010-02-09 18:00   ` [tip:x86/urgent] x86, apic: Don't use logical-flat mode when CPU hotplug may exceed 8 CPUs tip-bot for Suresh Siddha
2010-02-09 18:47     ` Yinghai Lu
2010-02-10  2:01       ` Suresh Siddha
2010-02-10  2:26         ` Yinghai Lu
2010-02-10  3:00           ` Yinghai Lu
2010-02-10  3:03             ` H. Peter Anvin
2010-02-10  3:04               ` Yinghai Lu
2010-02-10  3:42         ` Yinghai Lu
2010-02-10  6:27         ` tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100118201256.604267529@sbs-t61.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=ananth@in.ibm.com \
    --cc=hpa@zytor.com \
    --cc=lcm@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome