From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com,
alan@linux.intel.com, charles.f.johnson@intel.com,
Mark Allyn <mark.a.allyn@intel.com>
Subject: Re: [PATCH] Add Linux Driver for Intel Langwell Watchdog
Date: Mon, 18 Jan 2010 22:24:00 +0000 [thread overview]
Message-ID: <20100118222400.2b8fa0c2@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1263849859-23265-1-git-send-email-mark.a.allyn@intel.com>
> + /* send the threshold and soft_threshold via IPC to the Lincroft */
> + reg_data.payload1 = watchdog_device.soft_threshold;
> + reg_data.payload2 = watchdog_device.threshold;
> + ipc_set_watchdog(®_data);
That still doesn't seem to be merged upstream - someone needs poking to
at least get an IPC driver into staging.
> + * /dev/watchdog handling
> + */
> +static int langwell_open(struct inode *inode, struct file *file)
> +{
> + /* Miscdevice structure pointer already saved in private_data */
> +
> + struct watchdog_reg_data reg_data;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
File permissions will deal with that bit
> +
> + if (test_and_set_bit(0, &watchdog_device.driver_open))
> + return -ENOTTY;
EBUSY
next prev parent reply other threads:[~2010-01-18 22:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 21:24 Mark Allyn
2010-01-18 21:48 ` Marcel Holtmann
2010-01-18 22:24 ` Alan Cox [this message]
2010-01-19 0:07 ` Greg KH
2010-01-20 7:22 ` Pavel Machek
2010-01-20 12:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118222400.2b8fa0c2@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=charles.f.johnson@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.a.allyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®